Reject non-https download URLs from registry metadata#15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveFromMetadatareadsdownload_urlandtarballfrom the registry's JSON response and hands them straight to the fetcher. A compromised or MITM'd registry could returnfile:///etc/passwdorhttp://169.254.169.254/latest/meta-data/and we'd fetch it.Now requires scheme
httpsand a non-empty host before returning theArtifactInfo. Anything else getsErrUnsafeURL.This doesn't check IP ranges. That defense belongs in the fetcher's dialer where DNS rebinding can't sneak past it, and would also cover URLs from
URLBuilder.Download()and the template paths inresolveWithoutRegistry. Separate change.