fix: move workflow permissions from job level to workflow level#433
Closed
fix: move workflow permissions from job level to workflow level#433
Conversation
Job-level permissions are capped by workflow-level permissions. With workflow-level set to only `contents: read`, job-level write permissions were silently capped, breaking actions like markPullRequestReadyForReview.
jmeridth
force-pushed
the
fix/workflow-permissions-to-workflow-level
branch
from
8138eef to
83bef7a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts GitHub Actions workflow token permissions by moving permissions: from individual jobs to the workflow level to prevent job-level write permissions from being silently capped by more restrictive workflow-level defaults (which can cause Resource not accessible by integration failures).
Changes:
- Move job-scoped
permissionsdeclarations to workflow-levelpermissionsacross multiple workflows. - Broaden workflow-level permissions in multi-job workflows to the union required by all jobs to avoid permission caps.
- Align workflows that call reusable workflows to rely on workflow-level permissions rather than per-job blocks.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/stale.yml | Moves issue/PR permissions from job to workflow scope for stale issue automation. |
| .github/workflows/scorecard.yml | Elevates required Scorecard permissions to workflow scope (id-token, security-events). |
| .github/workflows/release.yml | Moves all release-related permissions to workflow scope and removes per-job restrictions. |
| .github/workflows/pr-title.yml | Moves reusable PR title workflow permissions to workflow scope. |
| .github/workflows/mark-ready-when-ready.yml | Fixes permission capping by declaring required write permissions at workflow level. |
| .github/workflows/codeql.yml | Moves CodeQL scan permissions to workflow scope. |
| .github/workflows/auto-labeler.yml | Moves PR labeling permissions to workflow scope for pull_request_target runs. |
Comment on lines
8
to
+14
| permissions: | ||
| contents: read | ||
| attestations: write | ||
| contents: write | ||
| discussions: write | ||
| id-token: write | ||
| packages: write | ||
| pull-requests: read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves permissions declarations from job level back to workflow level across all workflow files.
Why
Workflow-level
permissionssets the maximum token permissions for all jobs. Withcontents: readat workflow level, job-levelcontents: writewas silently capped, causingResource not accessible by integrationerrors (e.g.,markPullRequestReadyForReviewin mark-ready-when-ready).Notes