Skip to content

Add quality-playbook skill#1212

Closed
andrewstellman wants to merge 9 commits intogithub:stagedfrom
andrewstellman:quality-playbook-v1.2.0
Closed

Add quality-playbook skill#1212
andrewstellman wants to merge 9 commits intogithub:stagedfrom
andrewstellman:quality-playbook-v1.2.0

Conversation

@andrewstellman
Copy link
Copy Markdown
Contributor

Summary

  • Adds the quality-playbook skill (v1.2.0), which generates six quality artifacts for any codebase: a quality constitution (QUALITY.md), spec-traced functional tests, a code review protocol with regression test generation, an integration test protocol, a multi-model spec audit (Council of Three), and an AI bootstrap file (AGENTS.md)
  • Includes state machine completeness analysis (Step 5a) and missing safeguard detection for catching bugs that pattern analysis alone misses
  • Validated against 5 codebases across Python, Java, Scala, and TypeScript — all known bugs surfaced

What's included

  • skills/quality-playbook/SKILL.md — main skill definition
  • skills/quality-playbook/references/ — defensive patterns reference, test patterns reference
  • skills/quality-playbook/LICENSE.txt — license

Copilot AI review requested due to automatic review settings March 29, 2026 02:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the quality-playbook skill to v1.2.0 by expanding its guidance around regression-test generation from review findings, and adding new analysis areas (state machine completeness + missing safeguards) to improve defect discovery during quality playbook generation.

Changes:

  • Adds a “Phase 2” protocol for writing regression tests that confirm BUG findings.
  • Adds references for state machine tracing patterns and missing safeguard detection.
  • Bumps the skill version to 1.2.0 and updates the skills index entry accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
skills/quality-playbook/references/review_protocols.md Adds regression-test generation protocol after code review findings.
skills/quality-playbook/references/defensive_patterns.md Adds state machine patterns + missing safeguard patterns to the defensive patterns reference.
skills/quality-playbook/SKILL.md Updates skill description/version and adds step 5a + regression-test phase reference.
docs/README.skills.md Updates the quality-playbook row description to mention regression-test generation.

Copy link
Copy Markdown
Contributor

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-run the script to generate the README as something doesn't look right - the PR is removing the skill from the README

@andrewstellman
Copy link
Copy Markdown
Contributor Author

Can you re-run the script to generate the README as something doesn't look right - the PR is removing the skill from the README

Thanks, Aaron. I reran the script, hopefully it all looks okay now.

---
name: quality-playbook
description: "Explore any codebase from scratch and generate six quality artifacts: a quality constitution (QUALITY.md), spec-traced functional tests, a code review protocol with regression test generation, an integration testing protocol, a multi-model spec audit (Council of Three), and an AI bootstrap file (AGENTS.md). Works with any language (Python, Java, Scala, TypeScript, Go, Rust, etc.). Use this skill whenever the user asks to set up a quality playbook, generate functional tests from specifications, create a quality constitution, build testing protocols, audit code against specs, or establish a repeatable quality system for a project. Also trigger when the user mentions 'quality playbook', 'spec audit', 'Council of Three', 'fitness-to-purpose', 'coverage theater', or wants to go beyond basic test generation to build a full quality system grounded in their actual codebase."
description: 'Explore any codebase from scratch and generate six quality artifacts: a quality constitution (QUALITY.md), spec-traced functional tests, a code review protocol with regression test generation, an integration testing protocol, a multi-model spec audit (Council of Three), and an AI bootstrap file (AGENTS.md). Includes state machine completeness analysis and missing safeguard detection. Works with any language (Python, Java, Scala, TypeScript, Go, Rust, etc.). Use this skill whenever the user asks to set up a quality playbook, generate functional tests from specifications, create a quality constitution, build testing protocols, audit code against specs, or establish a repeatable quality system for a project. Also trigger when the user mentions 'quality playbook', 'spec audit', 'Council of Three', 'fitness-to-purpose', 'coverage theater', or wants to go beyond basic test generation to build a full quality system grounded in their actual codebase.'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just figured out why it's been dropped from the README, it's failing to parse the frontmatter because it's now using ' not " and then it's not escaping parts of the description.

Can you ensure things like 'quality playbook' are properly escaped so that it will generate the entry in the readme (I'll see if I can improve the scripts to surface that error up)

@andrewstellman
Copy link
Copy Markdown
Contributor Author

andrewstellman commented Mar 31, 2026 via email

@andrewstellman
Copy link
Copy Markdown
Contributor Author

Closing in favor of #1238 (clean branch, single commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants