Fix event type names for assistant messages#1224
Closed
moeyui1 wants to merge 2 commits intogithub:stagedfrom
Closed
Fix event type names for assistant messages#1224moeyui1 wants to merge 2 commits intogithub:stagedfrom
moeyui1 wants to merge 2 commits intogithub:stagedfrom
Conversation
Fix event type names for assistant messages per https://github.com/github/copilot-sdk/blob/main/nodejs/src/generated/session-events.ts
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Copilot SDK Node.js event type references and performs a broad restructuring/expansion of multiple plugins by adding many new agent/skill/reference files and simplifying plugin manifests to point at directories.
Changes:
- Fix assistant delta event type strings in
copilot-sdk-nodejs.instructions.mdto match the SDK’s actual event names. - Add multiple new agents/skills (and extensive reference docs/assets) across many plugins.
- Simplify many plugin manifests to reference
./agentsand/or normalize skill paths (e.g., remove trailing slashes).
Reviewed changes
Copilot reviewed 113 out of 306 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/go-mcp-development/.github/plugin/plugin.json | Switches plugin manifest agent/skill entries to directory/no-trailing-slash paths. |
| plugins/gem-team/agents/gem-reviewer.md | Adds a security/code review agent definition. |
| plugins/gem-team/agents/gem-implementer.md | Adds an implementation-focused agent definition. |
| plugins/gem-team/agents/gem-documentation-writer.md | Adds a documentation-writer agent definition. |
| plugins/gem-team/agents/gem-devops.md | Adds a DevOps-focused agent definition. |
| plugins/gem-team/agents/gem-browser-tester.md | Adds a browser/E2E testing agent definition. |
| plugins/gem-team/.github/plugin/plugin.json | Simplifies manifest to point at the agents directory. |
| plugins/frontend-web-dev/skills/playwright-generate-test/SKILL.md | Adds a Playwright test-generation skill. |
| plugins/frontend-web-dev/skills/playwright-explore-website/SKILL.md | Adds a Playwright website exploration skill. |
| plugins/frontend-web-dev/agents/electron-angular-native.md | Adds Electron/Angular/native review-mode instructions agent. |
| plugins/frontend-web-dev/.github/plugin/plugin.json | Simplifies agents to directory path; lists Playwright skills without trailing slashes. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/connection-references.md | Adds FlowStudio MCP connection reference documentation. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/action-types.md | Adds FlowStudio MCP action type reference documentation. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/MCP-BOOTSTRAP.md | Adds FlowStudio MCP bootstrap/how-to-call reference. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-debug/references/debug-workflow.md | Adds a Power Automate debugging workflow reference. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-debug/references/common-errors.md | Adds common Power Automate error reference material. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/trigger-types.md | Adds trigger templates/reference for flow building. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/flow-schema.md | Adds a flow definition schema reference. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/build-patterns.md | Adds ready-to-copy flow build pattern templates. |
| plugins/flowstudio-power-automate/.github/plugin/plugin.json | Normalizes skill paths by removing trailing slashes. |
| plugins/fastah-ip-geo-tools/skills/geofeed-tuner/references/snippets-python3.md | Adds Python 3 code snippet references for the geofeed tuner skill. |
| plugins/fastah-ip-geo-tools/skills/geofeed-tuner/assets/small-territories.json | Adds a JSON asset list used by geofeed tuning. |
| plugins/fastah-ip-geo-tools/skills/geofeed-tuner/assets/example/01-user-input-rfc8805-feed.csv | Adds an example RFC8805 geofeed CSV input. |
| plugins/fastah-ip-geo-tools/.github/plugin/plugin.json | Normalizes skill path by removing trailing slash. |
| plugins/edge-ai-tasks/.github/plugin/plugin.json | Simplifies manifest to point at the agents directory. |
| plugins/doublecheck/skills/doublecheck/assets/verification-report-template.md | Adds a verification report template asset. |
| plugins/doublecheck/agents/doublecheck.md | Adds a “Doublecheck” verification agent definition. |
| plugins/doublecheck/.github/plugin/plugin.json | Simplifies manifest to point at agents dir and normalizes skill path. |
| plugins/devops-oncall/skills/multi-stage-dockerfile/SKILL.md | Adds a multi-stage Dockerfile guidance skill. |
| plugins/devops-oncall/agents/azure-principal-architect.md | Adds an Azure principal architect agent definition (DevOps on-call plugin). |
| plugins/devops-oncall/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill paths. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-usecase-builder/SKILL.md | Adds a Dataverse SDK use-case builder skill. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-quickstart/SKILL.md | Adds a Dataverse SDK quickstart skill. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-production-code/SKILL.md | Adds a Dataverse SDK production-code skill. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-advanced-patterns/SKILL.md | Adds a Dataverse SDK advanced patterns skill. |
| plugins/dataverse-sdk-for-python/.github/plugin/plugin.json | Normalizes skill paths by removing trailing slashes. |
| plugins/database-data-management/skills/postgresql-code-review/SKILL.md | Adds a PostgreSQL-specific code review skill. |
| plugins/database-data-management/agents/postgresql-dba.md | Adds a PostgreSQL DBA agent definition. |
| plugins/database-data-management/agents/ms-sql-dba.md | Adds a MS SQL DBA agent definition. |
| plugins/database-data-management/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill paths. |
| plugins/csharp-mcp-development/skills/csharp-mcp-server-generator/SKILL.md | Adds a C# MCP server generator skill. |
| plugins/csharp-mcp-development/agents/csharp-mcp-expert.md | Adds a C# MCP expert agent definition. |
| plugins/csharp-mcp-development/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill paths. |
| plugins/csharp-dotnet-development/skills/dotnet-upgrade/SKILL.md | Adds a .NET upgrade analysis/execution skill. |
| plugins/csharp-dotnet-development/skills/dotnet-best-practices/SKILL.md | Adds .NET best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-xunit/SKILL.md | Adds xUnit best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-tunit/SKILL.md | Adds TUnit best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-nunit/SKILL.md | Adds NUnit best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-async/SKILL.md | Adds C# async best practices skill. |
| plugins/csharp-dotnet-development/skills/aspnet-minimal-api-openapi/SKILL.md | Adds ASP.NET minimal API + OpenAPI skill. |
| plugins/csharp-dotnet-development/agents/expert-dotnet-software-engineer.md | Adds an expert .NET software engineer agent definition. |
| plugins/csharp-dotnet-development/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill paths. |
| plugins/copilot-sdk/.github/plugin/plugin.json | Normalizes skill path by removing trailing slash. |
| plugins/context-engineering/skills/what-context-needed/SKILL.md | Adds a “what context is needed” skill. |
| plugins/context-engineering/skills/refactor-plan/SKILL.md | Adds a refactor planning skill. |
| plugins/context-engineering/skills/context-map/SKILL.md | Adds a context mapping skill. |
| plugins/context-engineering/agents/context-architect.md | Adds a context-architect agent definition. |
| plugins/context-engineering/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill paths. |
| plugins/clojure-interactive-programming/skills/remember-interactive-programming/SKILL.md | Adds an interactive programming reminder skill. |
| plugins/clojure-interactive-programming/agents/clojure-interactive-programming.md | Adds a Clojure interactive programming agent definition. |
| plugins/clojure-interactive-programming/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill path. |
| plugins/cast-imaging/agents/cast-imaging-structural-quality-advisor.md | Adds a CAST Imaging structural quality advisor agent definition. |
| plugins/cast-imaging/agents/cast-imaging-software-discovery.md | Adds a CAST Imaging discovery agent definition. |
| plugins/cast-imaging/agents/cast-imaging-impact-analysis.md | Adds a CAST Imaging impact analysis agent definition. |
| plugins/cast-imaging/.github/plugin/plugin.json | Simplifies manifest to point at agents dir. |
| plugins/azure-cloud-development/skills/azure-pricing/references/SERVICE-NAMES.md | Adds Azure Retail Prices API serviceName reference. |
| plugins/azure-cloud-development/skills/azure-pricing/references/REGIONS.md | Adds Azure Retail Prices API region name reference. |
| plugins/azure-cloud-development/skills/azure-pricing/references/COST-ESTIMATOR.md | Adds Azure cost estimation formulas reference. |
| plugins/azure-cloud-development/skills/azure-pricing/references/COPILOT-STUDIO-RATES.md | Adds Copilot Studio billing rates snapshot and estimation guidance. |
| plugins/azure-cloud-development/skills/azure-pricing/SKILL.md | Adds an Azure pricing skill integrating retail pricing + Copilot Studio credit estimation. |
| plugins/azure-cloud-development/agents/terraform-azure-planning.md | Adds an Azure Terraform planning agent definition. |
| plugins/azure-cloud-development/agents/terraform-azure-implement.md | Adds an Azure Terraform implementation agent definition. |
| plugins/azure-cloud-development/agents/azure-verified-modules-terraform.md | Adds an Azure AVM Terraform agent definition. |
| plugins/azure-cloud-development/agents/azure-verified-modules-bicep.md | Adds an Azure AVM Bicep agent definition. |
| plugins/azure-cloud-development/agents/azure-saas-architect.md | Adds an Azure SaaS architect agent definition. |
| plugins/azure-cloud-development/agents/azure-principal-architect.md | Adds an Azure principal architect agent definition (Azure cloud plugin). |
| plugins/azure-cloud-development/agents/azure-logic-apps-expert.md | Adds an Azure Logic Apps expert agent definition. |
| plugins/azure-cloud-development/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill paths. |
| plugins/awesome-copilot/skills/suggest-awesome-github-copilot-skills/SKILL.md | Adds a skill to suggest/install skills from awesome-copilot. |
| plugins/awesome-copilot/skills/suggest-awesome-github-copilot-instructions/SKILL.md | Adds a skill to suggest/install instruction files from awesome-copilot. |
| plugins/awesome-copilot/skills/suggest-awesome-github-copilot-agents/SKILL.md | Adds a skill to suggest/install custom agents from awesome-copilot. |
| plugins/awesome-copilot/agents/meta-agentic-project-scaffold.md | Adds a meta scaffold agent that pulls content from awesome-copilot. |
| plugins/awesome-copilot/.github/plugin/plugin.json | Simplifies manifest to point at agents dir; normalizes skill paths. |
| plugins/automate-this/.github/plugin/plugin.json | Normalizes skill path by removing trailing slash. |
| instructions/copilot-sdk-nodejs.instructions.md | Fixes assistant delta event type string literals (dot → underscore) in examples. |
| "./agents/gem-devops.md", | ||
| "./agents/gem-reviewer.md", | ||
| "./agents/gem-documentation-writer.md" | ||
| "./agents" |
There was a problem hiding this comment.
The PR title/description indicate this change is only about fixing assistant event type names, but this PR also introduces many new agents/skills and modifies numerous plugin manifests. This makes review/scope tracking difficult and increases the risk of unrelated regressions. Please either (a) update the PR description to cover the full scope and rationale, or (b) split into separate PRs (event-type fix vs. plugin content/manifest restructuring).
| "agents": [ | ||
| "./agents/expert-react-frontend-engineer.md", | ||
| "./agents/electron-angular-native.md" | ||
| "./agents" |
There was a problem hiding this comment.
Several plugin manifests were changed from enumerating specific agent files to referencing the entire ./agents directory. If the plugin loader expects file paths (not directories), this will break agent discovery and effectively remove agents from the plugin. Recommendation: keep explicit file paths (as before), or—if directory references are supported—add/point to a schema/validation check that guarantees directories are expanded deterministically and only include supported agent file types.
Suggested change
| "./agents" | |
| "./agents/frontend-web-dev.agent.md" |
Comment on lines
+1
to
+4
| --- | ||
| name: playwright-explore-website | ||
| description: 'Website exploration for testing using Playwright MCP' | ||
| --- |
There was a problem hiding this comment.
This PR adds multiple new skills/agents. If this repo maintains index files (e.g., docs/README.skills.md, docs/README.agents.md, etc.), those indices should be updated in the same PR so the new content is discoverable. I don’t see any docs index updates included here.
Comment on lines
+1
to
+7
| --- | ||
| description: 'Interactive verification agent for AI-generated output. Runs a three-layer pipeline (self-audit, source verification, adversarial review) and produces structured reports with source links for human review.' | ||
| name: Doublecheck | ||
| tools: | ||
| - web_search | ||
| - web_fetch | ||
| --- |
There was a problem hiding this comment.
The front matter name value uses capitalization (Doublecheck) while many other agents use lowercase, hyphenated identifiers (e.g., gem-reviewer). If name is used as a stable identifier for invocation, consider changing this to a lowercase/hyphenated form (e.g., doublecheck) to avoid inconsistencies and potential lookup issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix event type names for assistant messages per https://github.com/github/copilot-sdk/blob/main/nodejs/src/generated/session-events.ts
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.stagedbranch for this pull request.Description
Fix the event type names for assistant messages according to the actual definition in SDK: https://github.com/github/copilot-sdk/blob/main/nodejs/src/generated/session-events.ts
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.