Skip to content

poc: shell injection verification via skill directory name#1236

Closed
dorjoos wants to merge 1 commit intogithub:stagedfrom
dorjoos:poc/skill-injection
Closed

poc: shell injection verification via skill directory name#1236
dorjoos wants to merge 1 commit intogithub:stagedfrom
dorjoos:poc/skill-injection

Conversation

@dorjoos
Copy link
Copy Markdown

@dorjoos dorjoos commented Mar 31, 2026

Security verification PR — testing expression injection in skill-check.yml workflow.

This PR adds skills/$(printf RCE_CONFIRMED)/SKILL.md to verify that the ${{ steps.detect.outputs.skill_args }} expression in the 'Run skill-validator check' step evaluates shell command substitution when an attacker-controlled filename is used.

Expected: Running: .skill-validator/skill-validator check --verbose --skills skills/RCE_CONFIRMED appears in workflow logs, proving $(printf RCE_CONFIRMED) was executed.

@dorjoos dorjoos requested a review from aaronpowell as a code owner March 31, 2026 04:59
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Skill Validator Results

2 resource(s) checked | ✅ All checks passed

Full output
Specify one of --plugin, --skills, or --agents. Use --plugin to check an entire plugin directory.

Note: Errors were found. These are currently reported as warnings and do not block merge. Please review and address when possible.

@dorjoos
Copy link
Copy Markdown
Author

dorjoos commented Mar 31, 2026

Closing test PR — research complete.

@dorjoos dorjoos closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant