poc: shell injection verification via skill directory name#1236
Closed
dorjoos wants to merge 1 commit intogithub:stagedfrom
Closed
poc: shell injection verification via skill directory name#1236dorjoos wants to merge 1 commit intogithub:stagedfrom
dorjoos wants to merge 1 commit intogithub:stagedfrom
Conversation
Contributor
🔍 Skill Validator Results2 resource(s) checked | ✅ All checks passed Full output
|
Author
|
Closing test PR — research complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security verification PR — testing expression injection in skill-check.yml workflow.
This PR adds
skills/$(printf RCE_CONFIRMED)/SKILL.mdto verify that the${{ steps.detect.outputs.skill_args }}expression in the 'Run skill-validator check' step evaluates shell command substitution when an attacker-controlled filename is used.Expected:
Running: .skill-validator/skill-validator check --verbose --skills skills/RCE_CONFIRMEDappears in workflow logs, proving$(printf RCE_CONFIRMED)was executed.