C#: Use * ID for Locations in buildless.#20486
Closed
michaelnebel wants to merge 6 commits intogithub:mainfrom
Closed
C#: Use * ID for Locations in buildless.#20486michaelnebel wants to merge 6 commits intogithub:mainfrom
michaelnebel wants to merge 6 commits intogithub:mainfrom
Conversation
412d6a2 to
8332cd1
Compare
efbbdcb to
f6d0516
Compare
f6d0516 to
7b1f9f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we change the C# extraction to use
*IDs for Locations. This is a recommend pre-requisite for starting the work on C# overlay support.It turns out that there is a complication in relation to the "empty" location: There is a build in assumption in the QL library that we can refer to a unique single location for representing an "empty" location. That is,
Until now the empty location piggy backed on the fact that
0as positions) would be created on extraction.As a part of this PR we now extract a single synthetic "empty" location to be used to represent the empty location in the QL library.
DCA
*IDs the trap importer needs to do a lot of location de-duplication (for mono there is approximately 17m source location tuples, where 5m are duplicates - which are removed due to labelling on main). Correspondingly the increase in analysis time can be explained by the more bloated location table.