Open
Conversation
Contributor
Author
|
DCA alert changes look good. 173 new true positives! (I think the points-to modelling of |
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the py/use-of-exit-or-quit query to use the ApiGraphs API-based call matching, replacing the legacy points-to approach.
Changes:
- Replaced
LegacyPointsTodependency withsemmle.python.ApiGraphs. - Updated the query predicate to identify calls to the built-in
exit/quitviaAPI::builtin(...).getACall().asCfgNode().
Show a summary per file
| File | Description |
|---|---|
| python/ql/src/Statements/UseOfExit.ql | Migrates call matching from legacy points-to to API graphs for detecting exit()/quit() usage. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple port using API graphs.