Skip to content

C#: Only use nuget.exe on Windows or machines with Mono. #21993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michaelnebel wants to merge 6 commits into
base: main
Choose a base branch
from
+373 −308
Draft

C#: Only use nuget.exe on Windows or machines with Mono. #21993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f134948
C#: Use the build actions IsWindows in the NugetExeWrapper.
michaelnebel Jun 17, 2026
4f6a59f
C#: Invert logic in HasPackageSource.
michaelnebel Jun 17, 2026
e77ff07
C#: Re-factor the NugetExeWrapper, introduce an interface and a facto…
michaelnebel Jun 17, 2026
f901ae2
C#: Only download and use nuget.exe in case of windows or mono is ins…
michaelnebel Jun 17, 2026
b78c30a
C#: Rename NugetExeWrapper to PackagesConfigRestorer.
michaelnebel Jun 17, 2026
2675042
C#: Fix some code quality issues by replacing Path.Combine with Path.…
michaelnebel Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
304 changes: 0 additions & 304 deletions csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetExeWrapper.cs
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,13 @@ public HashSet<AssemblyLookupLocation> Restore()
reachableFeeds.UnionWith(reachableInheritedFeeds);
}

using (var nuget = new NugetExeWrapper(fileProvider, legacyPackageDirectory, logger, IsDefaultFeedReachable))
using (var packagesConfigRestore = PackagesConfigRestoreFactory.Create(fileProvider, legacyPackageDirectory, logger, IsDefaultFeedReachable))
{
var count = nuget.InstallPackages();
var count = packagesConfigRestore.InstallPackages();

if (nuget.PackageCount > 0)
if (packagesConfigRestore.PackageCount > 0)
{
compilationInfoContainer.CompilationInfos.Add(("packages.config files", nuget.PackageCount.ToString()));
compilationInfoContainer.CompilationInfos.Add(("packages.config files", packagesConfigRestore.PackageCount.ToString()));
compilationInfoContainer.CompilationInfos.Add(("Successfully restored packages.config files", count.ToString()));
}
}
Expand Down
Loading
Loading