QL-for-QL: Add up- and downgrade scripts#21997
Closed
MathiasVP wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to unblock CI by adding QL to the languages supported by misc/scripts/prepare-db-upgrade.sh and by committing the generated upgrade/downgrade schema scripts for the “Extract YAML comments” schema change (mirroring what was done for other languages in #21935).
Changes:
- Extend
prepare-db-upgrade.shto locate the QL dbscheme atql/ql/src/ql.dbscheme. - Add a QL upgrade directory under
ql/ql/lib/upgrades/<hash>/for the YAML-comments schema change. - Add a QL downgrade directory under
ql/downgrades/<hash>/for the same schema change.
Show a summary per file
| File | Description |
|---|---|
misc/scripts/prepare-db-upgrade.sh |
Adds a ql) case to select the correct QL dbscheme path for script generation. |
ql/ql/lib/upgrades/c50cdd7429a4598cd95f75c82b4ba453007159d9/upgrade.properties |
Declares the QL upgrade metadata for “Extract YAML comments”. |
ql/ql/lib/upgrades/c50cdd7429a4598cd95f75c82b4ba453007159d9/ql.dbscheme |
New-side dbscheme snapshot for the QL upgrade (but appears inverted vs intended change). |
ql/ql/lib/upgrades/c50cdd7429a4598cd95f75c82b4ba453007159d9/old.dbscheme |
Old-side dbscheme snapshot for the QL upgrade (but appears inverted vs intended change). |
ql/downgrades/87c1125b41a68de7353f538cd7fb73bd0f18bfe0/upgrade.properties |
Declares the QL downgrade metadata and deletes yaml_comments.rel. |
ql/downgrades/87c1125b41a68de7353f538cd7fb73bd0f18bfe0/ql.dbscheme |
Target dbscheme snapshot for the QL downgrade (includes yaml_comments). |
ql/downgrades/87c1125b41a68de7353f538cd7fb73bd0f18bfe0/old.dbscheme |
Source dbscheme snapshot for the QL downgrade (excludes yaml_comments). |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 1
Comment on lines
+97
to
+111
| yaml_aliases (unique int alias: @yaml_alias_node ref, | ||
| string target: string ref); | ||
|
|
||
| yaml_scalars (unique int scalar: @yaml_scalar_node ref, | ||
| int style: int ref, | ||
| string value: string ref); | ||
|
|
||
| yaml_errors (unique int id: @yaml_error, | ||
| string message: string ref); | ||
|
|
||
| yaml_locations(unique int locatable: @yaml_locatable ref, | ||
| int location: @location_default ref); | ||
|
|
||
| @yaml_locatable = @yaml_node | @yaml_error; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #21935 we added support for extraction YAML comments and provided upgrade and downgrade scripts for all languages except for QL.
The lack of upgrade and downgrade scripts is now causing CI failures. This PR adds QL to the list of languages for which the
misc/scripts/prepare-db-upgrade.shworks and runs it to generate the upgrade and downgrade scripts that would have been generated if it had been run prior to merging #21935.