Ignore unknown quota values in plan detection#125
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts how total_monthly_quota is aggregated per user during plan detection so that sentinel-like “unknown” quota values (e.g. very large integers) don’t override known Business/Enterprise/Pro/Pro+ quotas and thereby skew included-credit pool sizing and license summaries.
Changes:
- Added a shared “known quota” filter/selector (
isKnownMonthlyQuota,selectKnownMonthlyQuota) in the included-credits pipeline utilities. - Updated included-credit context generation and
UserUsageAggregatorquota aggregation to use the selector. - Added tests covering sentinel-like quota rows and ensuring user aggregation + license summaries stay aligned.
Show a summary per file
| File | Description |
|---|---|
| src/pipeline/aicIncludedCredits.ts | Introduces known-quota selection helpers and applies them when aggregating per-user quotas for pool sizing. |
| src/pipeline/aicIncludedCredits.test.ts | Adds unit/integration tests for ignoring unknown-high quotas in pool sizing and keeping aggregations aligned. |
| src/pipeline/aggregators/userUsageAggregator.ts | Updates per-user quota aggregation to prefer the maximum known quota instead of blindly taking the max numeric value. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some billing report rows can include unknown high quota values such as
2147483647alongside valid Business or Enterprise quotas. This PR updates plan detection to select the maximum known quota per user so those sentinel-like values do not override valid plan signals.Changes
fix: ignore unknown quota values in plan detectionTesting
npm test -- --run src/pipeline/aicIncludedCredits.test.ts src/pipeline/aggregators/pruAggregation.test.ts src/pipeline/aggregators/aicDiscountAggregation.test.tsnpm test -- --runnpm run lintnpm run buildChecklist
npm run lint)