Skip to content

Preserve JSON-RPC error data in .NET #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephentoub wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Preserve JSON-RPC error data in .NET #1425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dotnet/src/JsonRpc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,10 @@ private void HandleResponse(JsonElement message, JsonElement idProp)
var errorCode = errorProp.TryGetProperty("code", out var codeProp) && codeProp.ValueKind == JsonValueKind.Number
? codeProp.GetInt32()
: 0;
pending.TrySetException(new RemoteRpcException(errorMessage, errorCode));
var errorData = errorProp.TryGetProperty("data", out var dataProp)
? dataProp.Clone()
: (JsonElement?)null;
pending.TrySetException(new RemoteRpcException(errorMessage, errorCode, errorData));
Comment on lines +443 to +446
}
else if (message.TryGetProperty("result", out var resultProp))
{
Expand Down Expand Up @@ -899,12 +902,14 @@ internal sealed class ConnectionLostException() : IOException("The JSON-RPC conn
/// <summary>
/// Thrown when the remote side returns a JSON-RPC error response.
/// </summary>
internal sealed class RemoteRpcException(string message, int errorCode, Exception? innerException = null) : Exception(message, innerException)
internal sealed class RemoteRpcException(string message, int errorCode, JsonElement? errorData = null, Exception? innerException = null) : Exception(message, innerException)
{
/// <summary>JSON-RPC 2.0 reserved error code: requested method does not exist.</summary>
public const int MethodNotFoundErrorCode = -32601;

public int ErrorCode { get; } = errorCode;

public JsonElement? ErrorData { get; } = errorData.HasValue ? errorData.Value.Clone() : null;
}

/// <summary>
Expand Down
Loading