Skip to content

Increase smoke-claude max-turns from 2 to 10#3779

Merged
lpcox merged 1 commit into
mainfrom
fix/smoke-claude-max-turns
May 25, 2026
Merged

Increase smoke-claude max-turns from 2 to 10#3779
lpcox merged 1 commit into
mainfrom
fix/smoke-claude-max-turns

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented May 25, 2026

Problem

The Smoke Claude workflow frequently fails with isMaxTurnsExit=true. With only 2 turns, the agent often can't reliably call the add_comment safe output tool — it may spend a turn reading context or produce empty args, then hit the limit.

Fix

Increase max-turns from 2 to 10 to give the agent adequate headroom for the smoke test task.

Evidence

Multiple recent failures all show the same pattern:

attempt 1 failed: exitCode=1 isMaxTurnsExit=true
attempt 1: max_turns exit — not retriable via --continue

Example runs: 26409084634, 26381506302, 26405268263

The Smoke Claude workflow frequently fails with isMaxTurnsExit=true because
2 turns is insufficient for the agent to reliably call the add_comment
safe output tool. Increasing to 10 gives adequate headroom.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 25, 2026 16:13
@lpcox
Copy link
Copy Markdown
Collaborator Author

lpcox commented May 25, 2026

@copilot recompile the smoke claude workflow

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Smoke Claude Agentic Workflow configuration to reduce frequent smoke test failures caused by hitting the max-turns limit.

Changes:

  • Increase engine.max-turns in .github/workflows/smoke-claude.md from 2 to 10.
  • Update the compiled workflow lock file to run Claude Code with --max-turns 10 and set GH_AW_MAX_TURNS=10.
  • (Unintended/risky) .github/workflows/smoke-claude.lock.yml was regenerated with a different gh-aw compiler/action version and includes many unrelated changes beyond max-turns.
Show a summary per file
File Description
.github/workflows/smoke-claude.md Raises the configured max-turns for the smoke workflow engine.
.github/workflows/smoke-claude.lock.yml Updates the compiled workflow to reflect the higher max-turns, but also includes broad unrelated regeneration changes.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment on lines +1 to +2
# gh-aw-metadata: {"schema_version":"v3","frontmatter_hash":"a75ccaca28d8a92118b775463f4147d08fa278cc58b0b49f4f31352663bf4ab9","compiler_version":"v0.74.4","agent_id":"claude","agent_model":"claude-haiku-4-5"}
# gh-aw-manifest: {"version":1,"secrets":["ANTHROPIC_API_KEY","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GITHUB_TOKEN"],"actions":[{"repo":"actions/checkout","sha":"de0fac2e4500dabe0009e67214ff5f5447ce83dd","version":"v6.0.2"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"},{"repo":"github/gh-aw-actions/setup","sha":"d3abfe96a194bce3a523ed2093ddedd5704cdf62","version":"v0.74.4"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.25.29","digest":"sha256:e68f37e36962dcb3f3d1de680a49bc2302cefd001b941a7dc377155ec7ce42f4","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.25.29@sha256:e68f37e36962dcb3f3d1de680a49bc2302cefd001b941a7dc377155ec7ce42f4"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.25.29","digest":"sha256:d1219e4110684402aabbeb5a43858f26790c9d0be210581cf3f7a521bd2c87b6","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.25.29@sha256:d1219e4110684402aabbeb5a43858f26790c9d0be210581cf3f7a521bd2c87b6"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.25.29","digest":"sha256:8a71ad9e40454051672312917e51567abfb8251d7c294d086c48f63d84e4cb53","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.25.29@sha256:8a71ad9e40454051672312917e51567abfb8251d7c294d086c48f63d84e4cb53"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.1","digest":"sha256:287fad0236959f3b3d9936ea1ef8d5b4f135ef2a5f5789713495cbbef191e60c","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.1@sha256:287fad0236959f3b3d9936ea1ef8d5b4f135ef2a5f5789713495cbbef191e60c"},{"image":"ghcr.io/github/github-mcp-server:v1.0.4"},{"image":"node:lts-alpine","digest":"sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f","pinned_image":"node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f"}]}
GH_AW_COMMENT_ID: ${{ needs.activation.outputs.comment_id }}
GH_AW_ALLOWED_DOMAINS: "*.githubusercontent.com,anthropic.com,api.anthropic.com,api.github.com,api.snapcraft.io,archive.ubuntu.com,azure.archive.ubuntu.com,cdn.playwright.dev,codeload.github.com,crl.geotrust.com,crl.globalsign.com,crl.identrust.com,crl.sectigo.com,crl.thawte.com,crl.usertrust.com,crl.verisign.com,crl3.digicert.com,crl4.digicert.com,crls.ssl.com,files.pythonhosted.org,ghcr.io,github-cloud.githubusercontent.com,github-cloud.s3.amazonaws.com,github.com,host.docker.internal,json-schema.org,json.schemastore.org,keyserver.ubuntu.com,lfs.github.com,objects.githubusercontent.com,ocsp.digicert.com,ocsp.geotrust.com,ocsp.globalsign.com,ocsp.identrust.com,ocsp.sectigo.com,ocsp.ssl.com,ocsp.thawte.com,ocsp.usertrust.com,ocsp.verisign.com,packagecloud.io,packages.cloud.google.com,packages.microsoft.com,playwright.download.prss.microsoft.com,ppa.launchpad.net,pypi.org,raw.githubusercontent.com,registry.npmjs.org,s.symcb.com,s.symcd.com,security.ubuntu.com,sentry.io,statsig.anthropic.com,ts-crl.ws.symantec.com,ts-ocsp.ws.symantec.com,www.googleapis.com"
GITHUB_SERVER_URL: ${{ github.server_url }}
GITHUB_API_URL: ${{ github.api_url }}
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@lpcox lpcox closed this May 25, 2026
@lpcox lpcox reopened this May 25, 2026
Copilot stopped work on behalf of lpcox due to an error May 25, 2026 16:30
@lpcox lpcox merged commit 7ed13c0 into main May 25, 2026
90 of 99 checks passed
@lpcox lpcox deleted the fix/smoke-claude-max-turns branch May 25, 2026 16:31
@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

GitHub MCP: ✅ Connected (PR #3779: "Increase smoke-claude max-turns from 2 to 10")
GitHub.com Connectivity: ✅ HTTP 200
File Write/Read: ❌ File not found at expected path

Status: FAIL (1/3 tests passed)

cc @lpcox (author)

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

GitHub MCP: Retrieved PR #3779 ("Increase smoke-claude max-turns from 2 to 10")
GitHub.com connectivity: Pre-step verified
⚠️ File write/read: Test file not found at expected path
BYOK inference: Successfully running in offline mode

Mode: BYOK offline (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com

Status: PASS (3/4 core tests)

PR Author: @lpcox | Merged: 2026-05-25

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Codex: FAIL
PR titles: Increase smoke-claude max-turns from 2 to 10; fix: remove unused export from normalizeDockerHostPathPrefix
✅ Playwright, file write/bash, build
❌ GitHub MCP, safeinputs-gh, Tavily search, discussion query
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Gemini Engine Validation\n\n- GitHub MCP Testing: ❌ (mcpscripts tool missing)\n- GitHub.com Connectivity: ❌ (SSL error 35)\n- File Writing Testing: ✅\n- Bash Tool Testing: ✅\n\nOverall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Services Connectivity

Redis: Connection timeout (no PONG)
PostgreSQL pg_isready: No response
PostgreSQL query: Not tested (connection failed)

Result: ❌ FAIL — Unable to reach GitHub Actions services at host.docker.internal

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color all passed ✅ PASS
Go env all passed ✅ PASS
Go uuid all passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

All build and test operations completed successfully across all ecosystems.

Generated by Build Test Suite for issue #3779 · ● 11.4M ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants