-
Notifications
You must be signed in to change notification settings - Fork 340
feat: repo-level config via .github/workflows/aw.json #25227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e374c30
feat: add aw.json repo-level config with maintenance runs_on and disa…
Copilot e965c00
refactor: address code review - fix typo and improve test fixture iso…
Copilot 81218f5
Merge branch 'main' into copilot/add-support-for-aw-json-config
pelikhan 01a7982
refactor: use JSON struct tags and automatic deserialization for repo…
Copilot b3b9f36
fix: YAML injection safety and expires warning when maintenance disabled
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "https://github.com/github/gh-aw/schemas/repo_config_schema.json", | ||
| "title": "Repository Configuration Schema", | ||
| "description": "JSON Schema for the .github/workflows/aw.json repository-level configuration file for gh-aw agentic workflows", | ||
| "version": "1.0.0", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "maintenance": { | ||
| "description": "Configuration for the agentic-maintenance workflow. Set to false to disable maintenance entirely, or provide an object to configure it.", | ||
| "oneOf": [ | ||
| { | ||
| "type": "boolean", | ||
| "enum": [false], | ||
| "description": "Set to false to disable agentic maintenance and refuse features that rely on it (such as expires)." | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "description": "Agentic maintenance workflow configuration. Enables generation of agentics-maintenance.yml.", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "runs_on": { | ||
| "description": "The runner or runners to use for maintenance workflow jobs. Accepts a single label string or an array of labels.", | ||
| "oneOf": [ | ||
| { | ||
| "type": "string", | ||
| "minLength": 1, | ||
| "pattern": "^[^\\r\\n\\x00-\\x08\\x0b\\x0c\\x0e-\\x1f\\x7f]+$", | ||
| "description": "A single runner label for maintenance workflow jobs.", | ||
| "examples": ["ubuntu-latest", "ubuntu-slim", "self-hosted"] | ||
| }, | ||
| { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "minLength": 1, | ||
| "pattern": "^[^\\r\\n\\x00-\\x08\\x0b\\x0c\\x0e-\\x1f\\x7f]+$" | ||
| }, | ||
| "minItems": 1, | ||
| "description": "An array of runner labels for maintenance workflow jobs.", | ||
| "examples": [ | ||
| ["self-hosted", "linux"], | ||
| ["self-hosted", "linux", "x64"] | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When repoConfig.MaintenanceDisabled is true, the function returns early even if workflows contain
expiresconfigs. That meansexpireswill silently stop working (no maintenance workflow will run) which conflicts with the PR description’s claim that dependent features are “suppressed/refused”. Either update the behavior to emit an error/warning (especially in strict mode) when expires is present while maintenance is disabled, or adjust the description/docs to reflect thatexpiresbecomes a no-op.