Consider workflow scope or user-escalation pattern for merging PRs that modify workflow files#1825
Draft
Abishek-Newar wants to merge 1 commit intogithub:mainfrom
Draft
Consider workflow scope or user-escalation pattern for merging PRs that modify workflow files#1825Abishek-Newar wants to merge 1 commit intogithub:mainfrom
Abishek-Newar wants to merge 1 commit intogithub:mainfrom
Conversation
…at modify workflow files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add pre-flight file inspection to
MergePullRequestto detect workflow files and return a clear error message before attempting merge operations that would fail due to missing workflow OAuth scope.Why
Fixes #1815
What changed
Workflowscope constant topkg/scopes/scopes.gocontainsWorkflowFileshelper function to detect files in.github/workflows/or .github/workflows-lab/MergePullRequesthandler to check for workflow files before merge and return a descriptive errorMCP impact
merge_pull_requestnow returns an error message when the PR contains workflow files, explaining the workflow scope requirement and suggesting alternatives.Prompts tested (tool changes only)
Security / limits
The change proactively detects when the workflow scope would be required and provides guidance, rather than failing with a cryptic 403 error.
Tool renaming
deprecated_tool_aliases.goLint & tests
./script/lint./script/testDocs