Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderer/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ export interface GitifyPullRequestReview {

export type GitifyDiscussionState = DiscussionStateReason | 'OPEN' | 'ANSWERED';

export type GitifyPullRequestState = PullRequestState | 'DRAFT';
export type GitifyPullRequestState = PullRequestState | 'DRAFT' | 'MERGE_QUEUE';

export type GitifyIssueState = IssueState | IssueStateReason;

Expand Down
1 change: 1 addition & 0 deletions src/renderer/utils/notifications/filters/state.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ describe('renderer/utils/notifications/filters/state.ts', () => {
NOT_PLANNED: 'closed',
RESOLVED: 'closed',

MERGE_QUEUE: 'merged',
MERGED: 'merged',
DRAFT: 'draft',

Expand Down
1 change: 1 addition & 0 deletions src/renderer/utils/notifications/filters/state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ function mapStateToFilter(
case 'NOT_PLANNED':
case 'RESOLVED':
return 'closed';
case 'MERGE_QUEUE':
case 'MERGED':
return 'merged';
case 'DRAFT':
Expand Down
44 changes: 43 additions & 1 deletion src/renderer/utils/notifications/handlers/pullRequest.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,45 @@ describe('renderer/utils/notifications/handlers/pullRequest.ts', () => {
} as GitifySubject);
});

it('merge queue pull request state', async () => {
const mockPullRequest = mockPullRequestResponseNode({
state: 'OPEN',
isInMergeQueue: true,
});

nock('https://api.github.com')
.post('/graphql')
.reply(200, {
data: {
repository: {
pullRequest: mockPullRequest,
},
},
});

const result = await pullRequestHandler.enrich(
mockNotification,
mockSettings,
);

expect(result).toEqual({
number: 123,
state: 'MERGE_QUEUE',
user: {
login: mockAuthor.login,
html_url: mockAuthor.html_url,
avatar_url: mockAuthor.avatar_url,
type: mockAuthor.type,
},
reviews: null,
labels: [],
linkedIssues: [],
comments: 0,
milestone: null,
htmlUrl: 'https://github.com/gitify-app/notifications-test/pulls/123',
} as GitifySubject);
});

it('merged pull request state', async () => {
const mockPullRequest = mockPullRequestResponseNode({
state: 'MERGED',
Expand Down Expand Up @@ -349,6 +388,7 @@ describe('renderer/utils/notifications/handlers/pullRequest.ts', () => {
const cases = {
CLOSED: 'GitPullRequestClosedIcon',
DRAFT: 'GitPullRequestDraftIcon',
MERGE_QUEUE: 'GitMergeQueueIcon',
MERGED: 'GitMergeIcon',
OPEN: 'GitPullRequestIcon',
} satisfies Record<GitifyPullRequestState, string>;
Expand All @@ -368,6 +408,7 @@ describe('renderer/utils/notifications/handlers/pullRequest.ts', () => {
const cases = {
CLOSED: IconColor.RED,
DRAFT: IconColor.GRAY,
MERGE_QUEUE: IconColor.YELLOW,
MERGED: IconColor.PURPLE,
OPEN: IconColor.GREEN,
} satisfies Record<GitifyPullRequestState, IconColor>;
Expand Down Expand Up @@ -445,6 +486,7 @@ function mockPullRequestResponseNode(mocks: {
state: PullRequestState;
isDraft?: boolean;
merged?: boolean;
isInMergeQueue?: boolean;
}): PullRequestResponse {
return {
__typename: 'PullRequest',
Expand All @@ -453,7 +495,7 @@ function mockPullRequestResponseNode(mocks: {
state: mocks.state,
isDraft: mocks.isDraft ?? false,
merged: mocks.merged ?? false,
isInMergeQueue: false,
isInMergeQueue: mocks.isInMergeQueue ?? false,
url: 'https://github.com/gitify-app/notifications-test/pulls/123',
author: mockAuthor,
labels: { nodes: [] },
Expand Down
12 changes: 11 additions & 1 deletion src/renderer/utils/notifications/handlers/pullRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type { FC } from 'react';
import type { OcticonProps } from '@primer/octicons-react';
import {
GitMergeIcon,
GitMergeQueueIcon,
GitPullRequestClosedIcon,
GitPullRequestDraftIcon,
GitPullRequestIcon,
Expand All @@ -22,6 +23,9 @@ import type { FetchPullRequestByNumberQuery } from '../../api/graphql/generated/
import { DefaultHandler, defaultHandler } from './default';
import { getNotificationAuthor } from './utils';

type PullRequestReviews =
FetchPullRequestByNumberQuery['repository']['pullRequest']['reviews']['nodes'];

class PullRequestHandler extends DefaultHandler {
readonly type = 'PullRequest' as const;

Expand All @@ -35,6 +39,8 @@ class PullRequestHandler extends DefaultHandler {
let prState: GitifyPullRequestState = pr.state;
if (pr.isDraft) {
prState = 'DRAFT';
} else if (pr.isInMergeQueue) {
prState = 'MERGE_QUEUE';
}

const prComment = pr.comments?.nodes[0];
Expand Down Expand Up @@ -64,6 +70,8 @@ class PullRequestHandler extends DefaultHandler {
return GitPullRequestDraftIcon;
case 'CLOSED':
return GitPullRequestClosedIcon;
case 'MERGE_QUEUE':
return GitMergeQueueIcon;
case 'MERGED':
return GitMergeIcon;
default:
Expand All @@ -77,6 +85,8 @@ class PullRequestHandler extends DefaultHandler {
return IconColor.GREEN;
case 'CLOSED':
return IconColor.RED;
case 'MERGE_QUEUE':
return IconColor.YELLOW;
case 'MERGED':
return IconColor.PURPLE;
default:
Expand All @@ -94,7 +104,7 @@ class PullRequestHandler extends DefaultHandler {
export const pullRequestHandler = new PullRequestHandler();

export function getLatestReviewForReviewers(
reviews: FetchPullRequestByNumberQuery['repository']['pullRequest']['reviews']['nodes'],
reviews: PullRequestReviews,
): GitifyPullRequestReview[] {
if (!reviews.length) {
return null;
Expand Down