-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
refactor: extract helper functions from SearchIssues #36158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bimakw
wants to merge
3
commits into
go-gitea:main
Choose a base branch
from
bimakw:refactor/split-search-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Dec 17, 2025
e04b0bd to
8909fce
Compare
Author
|
Thanks @lunny for the review! Updated to use |
lunny
approved these changes
Dec 18, 2025
wxiaoguang
reviewed
Dec 18, 2025
- Add ErrOwnerOrgRequired custom error type to replace string comparison - Refactor error handling to use proper Go error pattern
8909fce to
70a5b58
Compare
Author
|
Thanks @wxiaoguang for the feedback! You're right - using string comparison for errors is fragile. I've added a proper custom error type |
wxiaoguang
reviewed
Dec 19, 2025
8a97ad1 to
1d28fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
modifies/api
This PR adds API routes or modifies them
modifies/go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
SearchIssuesfunction inrouters/api/v1/repo/issue.goby extracting common logic into reusable helper functions:parseIssueIsClosed(): Parses the "state" query parameter and returns the correspondingisClosedoptionparseIssueIsPull(): Parses the "type" query parameter and returns the correspondingisPulloptionbuildSearchIssuesRepoIDs(): Builds the list of repository IDs for issue search based on query parametersBenefits:
Changes:
SearchIssuesfunctionTest plan
/repos/issues/searchendpointRef: #35015