use sku currency codes in storefront components#1386
Open
pbennett1-godaddy wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 07574f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wcole1-godaddy
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix storefront currency formatting so product prices use the currency returned by catalog SKU pricing instead of hardcoded
USD.SKUGroup.priceRangeonly providesmin/max, but SKU prices includevalue.currencyCode. Product card and product details now read currency from SKU price data and only fall back toUSDwhenno currency is available. Cart creation also no longer sends hardcoded zero-value USD totals to
addDraftOrder, since totals are now calculated by the order API from line items.Changeset
Test Plan
Ran Biome checks on changed storefront files:
pnpm --filter @godaddy/react exec biome check src/components/storefront/product-card.tsx src/lib/godaddy/catalog-storefront-queries.tspnpm --filter @godaddy/react exec biome check src/components/storefront/hooks/use-add-to-cart.tspnpm --filter @godaddy/react exec biome check src/components/storefront/product-details.tsxRan typecheck:
pnpm --filter @godaddy/react typecheck