Add batch check command and safety features to CLI #46
+112
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features added: - Extended check command to support batch checking: `check <IP> <host1> <host2>...` - Added --quiet flag for check command (only return exit codes) - Added --any flag for check command (match ANY instead of ALL hosts) - Added --backup global flag to create backup before modifying hosts - Added --safe global flag to detect concurrent modifications - Added flushHostsfile() helper that implements backup and safety checks Command updates: - add, remove, clean now use flushHostsfile() for safe writes - Backward compatible: single-arg check behavior preserved Dependencies: - Updated go.mod to use local hostsfile library with VVV improvements Exit codes: - 0: Success (host(s) found or operation completed) - 1: Check failed (host not found) - 2: Invalid arguments This enables VVV vagrant plugin to: - Check hosts without sudo (read-only operation) - Only request sudo when hosts are actually missing
Member
|
To me make sense, what do you think @luthermonson? |
Contributor
|
great feature, huge fan of this. can you fix the lint error and we'll get this merged |
Contributor
Author
|
@luthermonson this is blocked by goodhosts/hostsfile#57, once that's merged and released this PR can be updated to use that which will fix CI |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal here is to add features so that when using vagrant we don't need to trigger a
sudocall if we don't have to. That means checks and batch operations. Likewise accounting for if the user walks away and we prompt them for a sudo password, then other programs change the hosts file while we're waiting for permission to make changesThis depends on goodhosts/hostsfile#57
Features added:
check <IP> <host1> <host2>...Command updates:
Dependencies:
Exit codes: