Use xarray.Dataset/Array.sizes instead of .dims#84
Open
timothyas wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Use xarray.Dataset/Array.sizes instead of .dims#84timothyas wants to merge 1 commit intogoogle-deepmind:mainfrom
timothyas wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
e4c0342 to
1ea79ba
Compare
|
+1 to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few places where the syntax
xarray.Dataset.dims[varname]is used to get the length of e.g.varname. This produces the following warning of to-be-deprecated behavior(for reference this is with xarray version 2024.5.0)
This PR makes the replacement suggested by the warning. I think these are all the spots where this functionality of
.dimsis used, it's at least a good start.