fix: remove unused service and redundant IAM bindings in workload identity setup script#481
Open
anguillanneuf wants to merge 1 commit intogoogle-github-actions:mainfrom
Open
fix: remove unused service and redundant IAM bindings in workload identity setup script#481anguillanneuf wants to merge 1 commit intogoogle-github-actions:mainfrom
anguillanneuf wants to merge 1 commit intogoogle-github-actions:mainfrom
Conversation
remove an unused internal service cloudcode-pa.googleapis.com remove redundant IAM bindings on the Workload Identity Pool's principal from the original script Signed-off-by: Tianzi Cai <tianzi@google.com>
anguillanneuf
requested review from
R2wenD2,
benw307,
cynthialong0-0 and
verbanicm
Author
|
@kschaab for a review when you have a chance. Ty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original fix for #444 dated in January is incomplete.
This change removes an unused Google internal service
cloudcode-pa.googleapis.comfor users in the setup script for Workload Identity Federation.It also removes redundant IAM bindings on the Workload Identity Pool's principal in Step 4. These IAM bindings are added in Step 5 on a connected service account to the Workload Identity Pool, different from its principal. GitHub Actions "impersonates" this connected service account, which has access to Google Cloud resources and services.
Lastly, it updates the description to correctly reflect the content of the shell script.
I have published this codelab that teaches about this setup.