feat: Fix a handful of small changes related to headers, logging and javadoc #780
+138
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_861215601
branch
2 times, most recently
from
7060b2f to
874cb25
Compare
…javadoc 1. **License Headers**: Adds the Apache License 2.0 header to several Java files (`BaseToolset.java`, `GoogleMapsTool.java`, `LoadMemoryTool.java`, `NamedToolPredicate.java`, `ToolPredicate.java`, `IntegrationConnectorTool.java`, and `ModelNameUtils.java`). 2. **Logging**: Replaces `System.out.println` and `System.err.println` with `slf4j` logger calls (`logger.error`) in `ExampleUtils.java`, `GoogleSearchTool.java`, and `IntegrationConnectorTool.java` for better error handling and logging practices. 3. **JSON Handling**: In `ExampleUtils.java`, switches from a dedicated `ObjectMapper` instance to using `JsonBaseModel.getMapper()` for JSON serialization. 4. **Thread Safety Doc**: Adds a note to the javadoc for `EventStream.java` indicating that the class is not thread-safe. 5. **`ToolConfirmation.java`**: Makes the `create()` method package-private. 6. **`BuiltInCodeExecutionTool.java`**: Adds a public static `INSTANCE` field for easy access. 7. **`ModelNameUtils.java`**: Makes the class `final`. PiperOrigin-RevId: 861745391
copybara-service
bot
force-pushed
the
test_861215601
branch
from
874cb25 to
0b63ca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Fix a handful of small changes related to headers, logging and javadoc
BaseToolset.java,GoogleMapsTool.java,LoadMemoryTool.java,NamedToolPredicate.java,ToolPredicate.java,IntegrationConnectorTool.java, andModelNameUtils.java).System.out.printlnandSystem.err.printlnwithslf4jlogger calls (logger.error) inExampleUtils.java,GoogleSearchTool.java, andIntegrationConnectorTool.javafor better error handling and logging practices.ExampleUtils.java, switches from a dedicatedObjectMapperinstance to usingJsonBaseModel.getMapper()for JSON serialization.EventStream.javaindicating that the class is not thread-safe.ToolConfirmation.java: Makes thecreate()method package-private.BuiltInCodeExecutionTool.java: Adds a public staticINSTANCEfield for easy access.ModelNameUtils.java: Makes the classfinal.