Add URL-based build sources (GCS/HTTPS) to cvd fetch#2238
Open
larsers wants to merge 1 commit intogoogle:mainfrom
Open
Add URL-based build sources (GCS/HTTPS) to cvd fetch#2238larsers wants to merge 1 commit intogoogle:mainfrom
larsers wants to merge 1 commit intogoogle:mainfrom
Conversation
Integrate URL support into the existing --*_build flags
(--default_build, --kernel_build, etc.) so that gs://, https://,
and http:// URLs can be used as build sources alongside CI and
directory builds.
Key changes:
- Add UrlBuildString and UrlBuild variant types to the build
type system (BuildString/Build std::variant)
- Add UrlDownloader class for GCS (via JSON API) and HTTP/HTTPS
downloads, reusing existing HttpClient infrastructure
- Scope auth headers to Google hosts only (*.googleapis.com,
*.google.com) to prevent credential leakage
- Handle automatic archive extraction (.zip, .tar.gz) and
selective file extraction via {filepath} suffix syntax
- Add unit tests for URL parsing, filename extraction, and
Google host validation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for GCS (gs://), HTTPS, and HTTP URLs as build sources in cvd fetch, alongside the existing Android CI and local directory build sources.
(BuildString/Build std::variant)
reusing existing HttpClient infrastructure
*.google.com) to prevent credential leakage to third-party servers
extraction via {filepath} suffix syntax (e.g.,
gs://bucket/images.zip{boot.img})
This change allows direct use of URLs in --default_build and other --*_build flags, e.g: