Swarming: Adds CountTasks endpoint & Refactors swarming Prpc request#5277
Merged
Conversation
IvanBM18
changed the title
Xeicker
reviewed
May 15, 2026
Xeicker
left a comment
Xeicker
left a comment
Collaborator
There was a problem hiding this comment.
For future PRs, when you move code and then add functionality it is a good practice to do each of those steps in separate commits for an easier review
IvanBM18
commented
May 15, 2026
IvanBM18
added
the
swarming
IvanBM18
force-pushed
the
feature/swarming/count_task_requests
branch
from
d45af03 to
562ec1b
Compare
IvanBM18
force-pushed
the
feature/swarming/count_task_requests
branch
from
562ec1b to
57886fc
Compare
Xeicker
approved these changes
May 15, 2026
Xeicker
left a comment
Xeicker
left a comment
Collaborator
There was a problem hiding this comment.
Other than some nits changes LGTM
Xeicker
approved these changes
May 18, 2026
jardondiego
reviewed
May 18, 2026
letitz
requested changes
May 19, 2026
Co-authored-by: Titouan Rigoudy <titouan@chromium.org>
letitz
reviewed
May 21, 2026
|
|
||
| if not creds.token: | ||
| creds.refresh(requests.Request()) | ||
| token = self._get_token() |
Collaborator
There was a problem hiding this comment.
IIUC this means we'll make requests with no tokens if we fail to get a token, which is bound to fail? ISTM we should bail out and not make a request if we cannot get an auth token for it.
I would either expose to callers that SwarmingApi methods might raise either GoogleAuthError or RequestException, or wrap those in a new exception type here: SwarmingError and let the caller deal with that.
Edit: I see your comment on the test, that this will show up as 401 errors. I still find it a bit surprising to ask the system to do something we know will fail, but I must admit it works. I'll let @javanlacerda decide how he feels about it.
| body=message_body) | ||
|
|
||
| response = self._make_request(_COUNT_TASKS_ENDPOINT, message_body) | ||
| logs.info('[Swarming] Response from CountTasks', response=response) |
Collaborator
There was a problem hiding this comment.
I would expect that debug-level logs are not logged in production, and only enabled if requested specifically somehow (environment variable?) during e.g. local testing. Anyway, thanks for considering it!
letitz
approved these changes
May 22, 2026
letitz
left a comment
letitz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM % adding one last test. Outstanding comments are left for @javanlacerda's consideration :)
javanlacerda
approved these changes
May 25, 2026
IvanBM18
added a commit
that referenced
this pull request
Jun 10, 2026
## Overview `SwarmingService` and other remote task services will now be instantiated in `RemoteTaskGate` based on the their feature flag. Now the `SwarmingService` will crash horribly at startup, this is done to avoid happing an api instances that does nothing, and a swarming service that just fails when called, with this new logic we make sure that all parts work as expected and if they dont.... well we just wont be able to fully schedule on envs where swarming is enabled. ### Background This PR comes from a discussion & agreement to a required change from [this review](#5277 (comment)) ## Changes - Raises an exception at `SwarmingService` constructor if the swarming config was not found - Updated `RemoteTaskGate` to conditionally instantiate services based on the linked feature flag. - This safeguards envs where the swarming feature flag is not enabled. - Added unit tests & updated a lot of them for the remote task gate changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the Swarming backpressure initiative, we needed to launch request to the prpc's
swarming.v2.Task/CountTasksendpoint so we can calculate the amount of fuzz tasks needed to schedule, to achieve this i moved the prpc request logic to its own module so that we can reuse code and keep responsibilities in separate files.Changes
api.pyfile in the swarming module.__init__.pytoapi.pyinit.pyservice.pyto useSwarmingAPIdirectly.SwarmingAPIto handle the prpc request logic such as token/auth logic, swarming config handling, and any other request logicTests