Skip RPATH patching on Schema v1 builds#5318
Open
notvictorl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, blackbox MSan jobs like
linux_msan_chromeattempt to patch the RPATHs of binaries to point to instrumented libs provided in the Dockerfileclusterfuzz/docker/chromium/base/Dockerfile
Line 53 in 4715844
since schema v0 archives did not include the instrumented libs in the archives. Schema v1 archives do include the instrumented libs that are needed by the binaries, but ClusterFuzz still tries to patch the RPATHs leading to mismatches causing
Bad builderrors.Solution:
ClusterFuzz can safely skip RPATH patching for MSan Schema v1 jobs so that the binaries can use the instrumented libs included in the same archive. To track the archive schema version after unpacking, a
.schema_versionfile andself._schema_versionare written so if the same build is re-used, ClusterFuzz isn't patching binaries that don't need patching.Note: We naively assume for
SymbolizedBuildthat the builds share the same schema version and uses the release builds schema version as it is unpacked first. This can cause issues if one build needs RPATH patching while the other does not.More info: https://crbug.com/516755275