Fix out-of-bounds vector access in StructDef::Deserialize#8988
Open
Noamismach wants to merge 3 commits intogoogle:masterfrom
Open
Fix out-of-bounds vector access in StructDef::Deserialize#8988Noamismach wants to merge 3 commits intogoogle:masterfrom
Noamismach wants to merge 3 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When parsing a binary schema (
.bfbs),StructDef::Deserializeallocates theindexesvector based on the number of fields (of.size()). However, it directly uses the parsedid()as the index for assignment without validating if theidis within the allocated bounds.If a schema contains a field with an
idthat is greater than or equal to the total number of fields, this results in an out-of-bounds vector write, causing memory corruption or a crash (e.g., catching a heap-buffer-overflow with AddressSanitizer).This PR adds a simple bounds check to ensure the
field_idis strictly less thanof.size()before writing to theindexesvector, safely aborting the deserialization if the schema is malformed.Testing: