fix: swapped argument order in new_inconsistent_union calls (#9001)#9010
Open
RenzoMXD wants to merge 1 commit intogoogle:masterfrom
Open
fix: swapped argument order in new_inconsistent_union calls (#9001)#9010RenzoMXD wants to merge 1 commit intogoogle:masterfrom
RenzoMXD wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_inconsistent_unioncalls inreflection_verifier.rs(field_type, field)but the function signature expects(field, field_type)Issue
Fixes #9001
The
new_inconsistent_union()function inverifier.rsexpects(field, field_type), but the call site inreflection_verifier.rswas passing the arguments in reverse order —(format!("{}_type", field.name()), field.name()). This caused confusing/misleading error messages when union verification failed.Test plan