[C++] Harden FlexBuffers scalar mutation verification#9089
Open
kmackinley wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reference::MutateBool()copy from a scalar source wide enough for forced-width bool storage.Motivation
FlexBuffers scalar mutation assumes the resolved scalar storage is distinct from the metadata used to resolve an indirect scalar. A malformed buffer can make those byte ranges overlap, so mutating the scalar can also mutate the offset used by later accesses. Rejecting this overlap during verification keeps verified indirect scalar references stable before callers use the public mutation APIs.
The bool mutation change preserves existing behavior while avoiding a wide copy from a 1-byte
boolobject when the parent storage width is larger.Tests
env ASAN_OPTIONS=detect_leaks=0:abort_on_error=1 UBSAN_OPTIONS=halt_on_error=1:print_stacktrace=1 LD_LIBRARY_PATH=$PWD/toolchains/apt/usr/lib/x86_64-linux-gnu toolchains/apt/usr/bin/ctest --test-dir build/flatbuffers-patch-asan --output-on-failureVerifyBuffer().