Fix FlexBuffers ArrayBufferView serialization bounds handling#9095
Open
kmackinley wants to merge 1 commit into
Open
Fix FlexBuffers ArrayBufferView serialization bounds handling#9095kmackinley wants to merge 1 commit into
kmackinley wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve
byteOffsetandbyteLengthwhen serializingArrayBufferViewinputs in the TypeScript FlexBuffers builder.Previously,
ArrayBuffer.isView(value)passedvalue.bufferdirectly towriteBlob(), which serialized the entire backingArrayBufferinstead of the visible view range. That could causeUint8Array.subarray(),DataView, and Node.jsBufferviews to serialize adjacent bytes outside the caller-selected bounds.Fix
writeBlobView()forArrayBufferViewinputs.byteOffsetandbyteLengthwhen copying blob bytes.ArrayBufferblob behavior unchanged.Uint8Array.subarray()andDataViewinputs.Tests
npm run compilenpm run lintnode JavaScriptFlexBuffersTest.jsfromtests/tswith a temporary local workspace package linkUint8Array.subarray()andDataViewview bounds