feat: Support format for 64-bit integer field types#409
Open
esraaghanemali wants to merge 2 commits intogoogle:mainfrom
Open
feat: Support format for 64-bit integer field types#409esraaghanemali wants to merge 2 commits intogoogle:mainfrom
esraaghanemali wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
775f962 to
2d26622
Compare
|
@timburks Hello, can you please take a look at this addition to the type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I update generator to add a
formatproperty to the schema for the proto definitions: int64, sint64, uint64, sfixed64, and fixed64As this was the case in OpenApi v2 specifications and we are migrating to openApi v3, we still need this info as we handle each one differently.
previous behavior
message MyMessage {
int64 my_field = 1;
}
the generated openApi V3 specifications are
but openApi v2 https://github.com/grpc-ecosystem/grpc-gateway/tree/main/protoc-gen-openapiv2 we got this