fix: fetch field property option for path variable and query (#436)#438
Open
ulysses-code wants to merge 1 commit intogoogle:mainfrom
Open
fix: fetch field property option for path variable and query (#436)#438ulysses-code wants to merge 1 commit intogoogle:mainfrom
ulysses-code wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@ulysses-code thanks for raising this PR - it's a fix I'd really like to see be approved & merged. Are you able to sign a CLA as requested above? |
Author
hi @pafrench , yes i have signed the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: fetch field property option for path variable and query (#436)
while path variable and query in message body, the
parametersin generated yaml should contain the overridden properties.Updated tests for openapiv3 as well