feat: Use omitzero for BypassActors to support empty arrays (#3859)#3869
Closed
maishivamhoo123 wants to merge 2 commits intogoogle:masterfrom
Closed
feat: Use omitzero for BypassActors to support empty arrays (#3859)#3869maishivamhoo123 wants to merge 2 commits intogoogle:masterfrom
omitzero for BypassActors to support empty arrays (#3859)#3869maishivamhoo123 wants to merge 2 commits intogoogle:masterfrom
Conversation
omitzero for BypassActors to support empty arrays (#3859)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3869 +/- ##
==========================================
- Coverage 92.40% 92.37% -0.03%
==========================================
Files 200 200
Lines 14382 14327 -55
==========================================
- Hits 13289 13234 -55
Misses 894 894
Partials 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #3859
by updating the BypassActors field in RepositoryRuleset to use the Go 1.24 omitzero JSON tag:
BypassActors []*BypassActor
json:"bypass_actors,omitzero"What this does:
Differentiates between an unset array and an empty array.
Simplifies the API by removing the need for workaround functions to clear BypassActors.
All existing tests pass successfully.
Note:
script/lint.sh and script/generate.sh may still report warnings due to duplicate operations in the generated metadata.
These issues are upstream and unrelated to the changes in this PR.
Looking forward to guidance from maintainers on handling the metadata and lint warnings.