Add option to use default Java import optimizer#1118
Open
ohle wants to merge 3 commits into
Open
Conversation
ohle
changed the title
|
I would love this to be an option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With v1.16.0, the Intellij plugin started automatically reformatting imports with no option to disable that. Before v1.16.0, it was possible to use custom import rules via Intellij settings, but these are now overridden by
google-java-format.See for example issue #986. This means that for code bases that were using
google-java-format <1.16.0and custom import rules, it is impossible to updategoogle-java-format.This pull request adds a checkbox to the Intellij plugin's settings (default on) that, when off, will fall back to Intellij's default import optimizer, enabling such projects to use current versions of
google-java-formatwith their custom import rules.Fixes #986