Remove the requirement for CharStream patterns to be anchored with ^.#1348
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 16, 2026
Merged
Remove the requirement for CharStream patterns to be anchored with ^.#1348copybara-service[bot] merged 1 commit intomasterfrom
CharStream patterns to be anchored with ^.#1348copybara-service[bot] merged 1 commit intomasterfrom
Conversation
…`^`. This apparently stemmed only from the use of `Matcher.find()` where `.lookingAt()` would be more appropriate. Also inline `fullCommentPattern()`. There doesn't seem to be any reason for it alone to be a separate method, and it was flagged by static analysis with a suggestion that it should in fact be a static final. PiperOrigin-RevId: 884437383
copybara-service
bot
force-pushed
the
test_883810093
branch
from
e297f6f to
d2f234d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the requirement for
CharStreampatterns to be anchored with^.This apparently stemmed only from the use of
Matcher.find()where.lookingAt()would be more appropriate.Also inline
fullCommentPattern(). There doesn't seem to be any reason for it alone to be a separate method, and it was flagged by static analysis with a suggestion that it should in fact be a static final.