Skip to content

fix: two silent math bugs in IntegratedDiscreteDDIMStep and QK-norm attention scale #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dhakshin2007 wants to merge 2 commits into
base: main
Choose a base branch
from

fix: use exp2 for norm_qk_scale to correctly exponentiate log-space p…

683fc91
Select commit
Loading
Failed to load commit list.
Open

fix: two silent math bugs in IntegratedDiscreteDDIMStep and QK-norm attention scale #29

fix: use exp2 for norm_qk_scale to correctly exponentiate log-space p…
683fc91
Select commit
Loading
Failed to load commit list.
Google CLA / cla/google succeeded Mar 15, 2026 in 1s

✅ All contributors are covered under a CLA with Google

See https://cla.developers.google.com/ for more info about Google's Contributor License Agreement (CLA).

ℹ️ Googlers: Go here to view more details and manage scans for this pull request.

Details

The following contributors were found for this pull request:

✅ 683fc91 Author: @Dhakshin2007 <179742818+Dhakshin2007​@users.noreply.github.com>

(Only the first commit for a unique contributor is listed.)

View more details on Google CLA