give a detailed error message in case of indentation mismatches in multiline jsonnet blocks #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
johnbartholomew
left a comment
johnbartholomew
left a comment
There was a problem hiding this comment.
Could you fix the indentation? The new code doesn't match the rest of the file (which doesn't match google3 standard)
| if (chomp_trailing_nl) { | ||
| assert(data.back() == '\n'); | ||
| data.pop_back(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Looks like the chomp_trailing_nl logic got dropped. I suspect that's causing the test failures (but haven't verified)
Contributor
Author
There was a problem hiding this comment.
Yes, sorry, this is still WIP. Will fix soon.
Collaborator
|
@simonff Do you expect to have time to update this? If not, I can take it over to get it merged. |
Contributor
Author
|
Please take it over if you have time! |
Co-Authored-By: John Bartholomew <jpa.bartholomew@gmail.com>
johnbartholomew
force-pushed
the
master
branch
from
911b6ff to
8805d9c
Compare
Collaborator
|
Rebased, cleaned up the whitespace, put chomping back in, updated the test in lexer_test.cpp. |
He-Pin
added a commit
to He-Pin/sjsonnet
that referenced
this pull request
Feb 10, 2026
He-Pin
added a commit
to He-Pin/sjsonnet
that referenced
this pull request
Feb 10, 2026
He-Pin
added a commit
to He-Pin/sjsonnet
that referenced
this pull request
Feb 10, 2026
stephenamar-db
pushed a commit
to databricks/sjsonnet
that referenced
this pull request
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.