Merged
Conversation
jaschdoc
commented
Feb 9, 2026
jaschdoc
force-pushed
the
gp-compiletestkotlin-warnings
branch
from
b35d5af to
cf6321e
Compare
hfmehmed
approved these changes
Feb 10, 2026
|
بتاريخ الثلاثاء، 10 فبراير 2026، جاء من Jakob Schneider <
***@***.***>:
… Merged #2780 <#2780> into main.
—
Reply to this email directly, view it on GitHub
<#2780 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/B5W54ZAOTBGZY2EQ753HJSD4LGXNRAVCNFSM6AAAAACUPNUCMKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSGY3DSNZZGE3DGMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes calls the deprecated
StringBuilder.appendlnmethod and replaces it withStringBuilder.appendLine. It also asserts thatFile.getNameis a non-null string and throws an error otherwise. Maybe the explicit throw can be omitted if it is handled by Kotlin's implicit non-null assertions? AlthoughFile.getNameis annotated withNotNullit still seems safer to throw at the binding site.