Update absl dependencies in CMakeLists.txt#3215
Open
katbohm wants to merge 1 commit into
Open
Conversation
Temporary fix for b/283987730 (failing build due to new protobuf having absl dependencies).
kkeshava
approved these changes
Sep 18, 2023
|
I have trialled this However, this change seems to have no effect on fixing the build for |
I should note that this was for building CPP |
gnomesysadmins
pushed a commit
to GNOME/gnome-build-meta
that referenced
this pull request
Oct 2, 2023
We need the following CMake arguments inside libphonenumber: - USE_BOOST - BUILD_TESTING - FETCHCONTENT_FULLY_DISCONNECTED These CMake arguements are required because there is a linking issue when using the new version of protobuf, which fails to link abseil when building. - google/libphonenumber#3215 Above is a link that will take you to an upstream pull request that is yet to be completed. In the meantime, we can still achieve a successfull build by following: - https://github.com/flathub/org.gnome.Calls/blob/master/org.gnome.Calls.yaml
nephros
pushed a commit
to nephros/libphonenumber
that referenced
this pull request
Dec 9, 2023
nephros
pushed a commit
to nephros/libphonenumber
that referenced
this pull request
Dec 9, 2023
nephros
pushed a commit
to nephros/libphonenumber
that referenced
this pull request
Dec 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for b/283987730 (failing build due to new protobuf having absl dependencies).
There is currently an issue with linking of Protobuf version 22.0 and newer.
This is caused by an added dependency to Abseil, and the transitive dependencies that are not propagated correctly.
This fix is working for Protobuf version 23.4 and newer.
Approximately from Protobuf version 23.4, the find_package(protobuf) which uses the embedded FindProtobuf package from CMake, have been updated to know about the Abseil dependency.
This PR is adding some needed dependencies.