Skip to content

Add support to protobuf 3.25.1#3394

Open
sergiomb2 wants to merge 2 commits into
google:masterfrom
sergiomb2:master
Open

Add support to protobuf 3.25.1#3394
sergiomb2 wants to merge 2 commits into
google:masterfrom
sergiomb2:master

Conversation

@sergiomb2

Copy link
Copy Markdown

new-protobuf-cmake-logic.patch

@sergiomb2 sergiomb2 requested a review from a team as a code owner January 20, 2024 22:46
@google-cla

google-cla Bot commented Jan 20, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Vogtinator

Copy link
Copy Markdown

This breaks building shared libraries here.

It can be fixed and simplified a lot by avoiding the proto-object intermediate library: sergiomb2#1

@sergiomb2

Copy link
Copy Markdown
Author

I just maintain package libphonenumber on Fedora Linux , I will test it Thank you

@sergiomb2

Copy link
Copy Markdown
Author

❌ Missing CLA from one or more contributors . @Vogtinator can you sign the CLA ?

@Vogtinator

Copy link
Copy Markdown

I'll have to ask around a bit. Supposedly we have a corporate CLA signed, so my address would just need to be added to the list.

@Vogtinator

Copy link
Copy Markdown

I'll have to ask around a bit. Supposedly we have a corporate CLA signed, so my address would just need to be added to the list.

That's done now, but with a different mail address. Can you just amend my commit with s/suse.de/suse.com/?

@sergiomb2

sergiomb2 commented Feb 22, 2024

Copy link
Copy Markdown
Author

yes, replace your commit do a new pull request to me
please
I will rebase with your commit

@lonnieashley72

lonnieashley72 commented Feb 22, 2024 via email

Copy link
Copy Markdown

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 23, 2024
https://build.opensuse.org/request/show/1149426
by user Vogtinator + anag+factory
- Update to version 8.13.30:
  * Update alternate formatting data, phone metadata, geocoding
    data, carrier data
  * Updated / refreshed time zone meta data.
  * New geocoding data
- Add patch submitted to upstream at gh#google/libphonenumber#3394
  to fix building with protobuf 3.25.1:
  * 0001-Add-support-to-protobuf-3.25.1.patch
- Add patch submitted in gh#sergiomb2/libphonenumber#1 by
  Fabian Vogt:
  * 0002-Avoid-intermediate-proto-object-library.patch

- Update to version 8.13.23: (forwarded request 1149395 from alarrosa)
sergiomb2 and others added 2 commits February 25, 2024 01:16
new-protobuf-cmake-logic.patch
The use of proto-object breaks building shared libs and it doesn't make
sense to install it. Instead of TARGET, use generate_protobuf with OUT_VAR.
@sergiomb2

Copy link
Copy Markdown
Author

done ! , please ignore the spammer

@Vogtinator

Copy link
Copy Markdown

@rohininidhi @mandlil

Can anyone please have a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants