Skip to content

Fix env in open source #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 3, 2026
Merged

Fix env in open source #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mediapy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
from __future__ import annotations

__docformat__ = 'google'
__version__ = '1.2.5'
__version__ = '1.2.6'
__version_info__ = tuple(int(num) for num in __version__.split('.'))

import base64
Expand Down Expand Up @@ -1233,7 +1233,9 @@ def _run_ffmpeg(
The subprocess.Popen object with running ffmpeg process.
"""
argv = []
env: Any = {}
# In open source, keep env=None to preserve default behavior.
# Context: https://github.com/google/mediapy/pull/62
env: Any = None # pylint: disable=unused-variable
ffmpeg_path = _get_ffmpeg_path()

# Allowed input and output files are not supported in open source.
Expand Down
Loading