Fix wrong parent when nesting perf metrics#1066
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
fc0b587 to
dbb6728
Compare
dbb6728 to
8d04416
Compare
8d04416 to
b0cb617
Compare
PiperOrigin-RevId: 868486420
b0cb617 to
1512da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wrong parent when nesting perf metrics
The refer_inference is currenlty nested under actor_training. Even though it is logically triggered before actor_training, its completion callback might run after actor_training has started. If actor_training is an active group on the same device timeline, the tracing infrastructure would incorrectly nest refer_inference under actor_training. Fixing the parent group to be at initiation time.
verified by manual launch.
https://screenshot.googleplex.com/5QmxLA7ZeTt8axQ