[anneal][v2] Check archive Lake cache reuse#3453
Open
mdittmer wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi #3453 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mdittmer
force-pushed
the
Gk6ir6ucgyyji67sqkhteqq3wjxijq7at
branch
from
bbe5f84 to
3c9a754
Compare
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
from
d13276c to
951c890
Compare
mdittmer
force-pushed
the
Gk6ir6ucgyyji67sqkhteqq3wjxijq7at
branch
from
3c9a754 to
9cb45f6
Compare
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
from
951c890 to
2c07e27
Compare
mdittmer
force-pushed
the
Gk6ir6ucgyyji67sqkhteqq3wjxijq7at
branch
from
9cb45f6 to
83b372d
Compare
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
from
2c07e27 to
0985f2c
Compare
Findings: the symlink-free v1 contract depends on a fully read-only extracted Aeneas archive being usable by a fresh generated workspace with a complete relative manifest, lake --old, and no package reconfiguration or cache rebuild. In response, the omnibus archive layout check now extracts the archive, asserts Aeneas is read-only, creates a tiny generated workspace and relative locked manifest, then runs lake --old build Generated and lake env lean --json against the archive to catch regressions. gherrit-pr-id: Gk6ir6ucgyyji67sqkhteqq3wjxijq7at
mdittmer
force-pushed
the
Gf5g4ujwxwoivi2uce2w3zt2hemew6jfi
branch
from
0985f2c to
7faaf99
Compare
mdittmer
force-pushed
the
Gk6ir6ucgyyji67sqkhteqq3wjxijq7at
branch
from
83b372d to
aab24b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings: the symlink-free v1 contract depends on a fully read-only extracted Aeneas archive being usable by a fresh generated workspace with a complete relative manifest, lake --old, and no package reconfiguration or cache rebuild. In response, the omnibus archive layout check now extracts the archive, asserts Aeneas is read-only, creates a tiny generated workspace and relative locked manifest, then runs lake --old build Generated and lake env lean --json against the archive to catch regressions.
Latest Update: v6 — Compare vs v5
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gk6ir6ucgyyji67sqkhteqq3wjxijq7at && git checkout -b pr-Gk6ir6ucgyyji67sqkhteqq3wjxijq7at FETCH_HEADCheckout
git fetch origin refs/heads/Gk6ir6ucgyyji67sqkhteqq3wjxijq7at && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gk6ir6ucgyyji67sqkhteqq3wjxijq7at && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.