Skip to content

Set default for brand_guidelines_enabled to True in Pmax examples. #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenRKarl merged 1 commit into from
Mar 9, 2026
Merged

Set default for brand_guidelines_enabled to True in Pmax examples. #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/advanced_operations/add_performance_max_campaign.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ def create_asset_group_signal_operations(
"-b",
"--brand_guidelines_enabled",
type=bool,
default=False,
default=True,
help=(
"A boolean value indicating if the created campaign is enabled "
"for brand guidelines."
Expand Down
25 changes: 17 additions & 8 deletions examples/shopping_ads/add_performance_max_retail_campaign.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
https://developers.google.com/google-ads/api/docs/conversions/overview#conversion_actions
"""


import argparse
from datetime import datetime, timedelta
import sys
Expand Down Expand Up @@ -390,20 +389,30 @@ def create_performance_max_campaign_operation(
)

# Optional fields
campaign.start_date_time = (datetime.now() + timedelta(1)).strftime("%Y%m%d 00:00:00")
campaign.end_date_time = (datetime.now() + timedelta(365)).strftime("%Y%m%d 23:59:59")
campaign.start_date_time = (datetime.now() + timedelta(1)).strftime(
"%Y%m%d 00:00:00"
)
campaign.end_date_time = (datetime.now() + timedelta(365)).strftime(
"%Y%m%d 23:59:59"
)

# Configures the optional opt-in/out status for asset automation settings.
for asset_automation_type_enum in [
client.enums.AssetAutomationTypeEnum.GENERATE_IMAGE_EXTRACTION,
client.enums.AssetAutomationTypeEnum.FINAL_URL_EXPANSION_TEXT_ASSET_AUTOMATION,
client.enums.AssetAutomationTypeEnum.TEXT_ASSET_AUTOMATION,
client.enums.AssetAutomationTypeEnum.GENERATE_ENHANCED_YOUTUBE_VIDEOS,
client.enums.AssetAutomationTypeEnum.GENERATE_IMAGE_ENHANCEMENT
client.enums.AssetAutomationTypeEnum.GENERATE_IMAGE_ENHANCEMENT,
]:
asset_automattion_setting: Campaign.AssetAutomationSetting = client.get_type("Campaign").AssetAutomationSetting()
asset_automattion_setting.asset_automation_type = asset_automation_type_enum
asset_automattion_setting.asset_automation_status = client.enums.AssetAutomationStatusEnum.OPTED_IN
asset_automattion_setting: Campaign.AssetAutomationSetting = (
client.get_type("Campaign").AssetAutomationSetting()
)
asset_automattion_setting.asset_automation_type = (
asset_automation_type_enum
)
asset_automattion_setting.asset_automation_status = (
client.enums.AssetAutomationStatusEnum.OPTED_IN
)
campaign.asset_automation_settings.append(asset_automattion_setting)

return mutate_operation
Expand Down Expand Up @@ -1239,7 +1248,7 @@ def print_response_details(response: MutateGoogleAdsResponse) -> None:
"-b",
"--brand_guidelines_enabled",
type=bool,
default=False,
default=True,
help=(
"A boolean value indicating if the created campaign is enabled "
"for brand guidelines."
Expand Down