fix(bq_driver): Prevent crash when listing datasets for invalid projects#1241
fix(bq_driver): Prevent crash when listing datasets for invalid projects#1241Anshu6250 wants to merge 2 commits into
Conversation
a10337a to
e2e478a
Compare
| // Trim leading/trailing whitespace | ||
| project_id.erase(0, project_id.find_first_not_of(" \t")); | ||
| project_id.erase(project_id.find_last_not_of(" \t") + 1); | ||
| project_id.erase(0, project_id.find_first_not_of(" \t\n\r")); |
There was a problem hiding this comment.
please document the code here
|
@shivamd-gpartner @Anshu6250 Is this change still valid? |
4303f60 to
07c65b3
Compare
07c65b3 to
4fdb146
Compare
4fdb146 to
427017e
Compare
sachinpro
left a comment
There was a problem hiding this comment.
A few questions:
- If invalid additional project is provided, is the driver throwing an error or crashing?
- If an error is sent, what is the error message and for what API?
- In case of crash, it cannot be happening at the client SDK level. So we need to fix the client library or the driver.
We will not be introducing any extra validations which impact performance to fix a crash.
|
This PR resolves an issue where the driver would crash when encountering invalid or inaccessible project IDs configured via the "Additional Projects" DSN setting.
