impl(bq_driver): Implements DefaultStringColumnLength truncation logic#1356
Open
Anshu6250 wants to merge 17 commits into
Open
impl(bq_driver): Implements DefaultStringColumnLength truncation logic#1356Anshu6250 wants to merge 17 commits into
Anshu6250 wants to merge 17 commits into
Conversation
|
|
||
| if (type_status_record.GetValue() == SQL_VARCHAR || | ||
| type_status_record.GetValue() == SQL_VARBINARY) { | ||
| if (type_status_record.GetValue() == SQL_VARCHAR) { |
Collaborator
There was a problem hiding this comment.
why is this changed?
Collaborator
Author
There was a problem hiding this comment.
changes are reverted
| dest_data.buflen, src_len, | ||
| dest_data.buflen, dest_data.result_len); | ||
| } | ||
| if (dest_type == SQL_C_BINARY) { |
Collaborator
There was a problem hiding this comment.
why is this needed?
Collaborator
Author
There was a problem hiding this comment.
We need this code so SQLGetData(..., SQL_C_BINARY) works for string columns; it copies raw bytes, reports correct length, and only truncates when the buffer is too small—not because of DefaultStringColumnLength.
Anshu6250
changed the title
| using google::cloud::odbc_internal::StatusRecord; | ||
|
|
||
| StatusRecord WriteToApplicationBuffer(DSValue const& ds_val, | ||
| StatusRecord WriteToApplicationBuffer(StatementHandle& stmt_handle, |
Collaborator
There was a problem hiding this comment.
pass it as const
|
|
||
| StatusRecord WriteDSRow(DSRow const& ds_row, RowSchema const& schema, | ||
| DescriptorHandle& ard, int row_num) { | ||
| StatusRecord WriteDSRow(StatementHandle& stmt_handle, DSRow const& ds_row, |
Collaborator
There was a problem hiding this comment.
pass stmt_handle as const and everywhere else
|
|
||
| EXPECT_EQ(Disconnect(conn), SQL_SUCCESS); | ||
| } | ||
| #ifdef BQ_DRIVER_INTEGRATION_TESTS |
Collaborator
There was a problem hiding this comment.
instead of connection test , put them under data translation test or statement test file
Anshu6250
force-pushed
the
test_truncation11
branch
from
db1bf1f to
a56608c
Compare
| HandleType kType = HandleType::kStmtHandle; | ||
|
|
||
| inline ConnectionHandle* GetConnectionHandle() { return conn_handle_; }; | ||
| inline ConnectionHandle const* GetConnectionHandle() const { |
Collaborator
There was a problem hiding this comment.
why do you need this, this seems redundant , we already have GetConnectionHandle() above
shivamd-gpartner
approved these changes
Jan 29, 2026
sachinpro
force-pushed
the
test_truncation11
branch
from
b854479 to
358f4e0
Compare
sachinpro
force-pushed
the
test_truncation11
branch
from
358f4e0 to
388fd20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the DefaultStringColumnLength configuration option to truncate STRING columns to a user-specified maximum length, addressing customer issue b/406545117 (tracked by b/391855319)
gha: macOS & Windows pipeline: link