fix(bq_driver): Fix tracing file size and file count#1454
Conversation
NeerajDwivedii
force-pushed
the
update_trace_config
branch
from
631976b to
e546d96
Compare
NeerajDwivedii
force-pushed
the
update_trace_config
branch
from
e546d96 to
7177ea8
Compare
| if (trace_option != nullptr && trace_option->max_threads > 0) { | ||
| max_threads = trace_option->max_threads; | ||
| } | ||
| int max_threads = (trace_option != nullptr) ? trace_option->max_threads : 0; |
There was a problem hiding this comment.
keep default thread as 8 not 0.
| fclose(fp_); | ||
| fp_ = nullptr; | ||
| } | ||
| static absl::TimeZone const kTimeZone = absl::LocalTimeZone(); |
There was a problem hiding this comment.
can you move this logic in a separate function
NeerajDwivedii
force-pushed
the
update_trace_config
branch
from
e6748b8 to
095d83f
Compare
|
@sachinpro PR ready for review |
sachinpro
left a comment
sachinpro
left a comment
There was a problem hiding this comment.
I hope you tested the logging E2E with this PR on windows.
I am approving this but please provide the default values for the max file size and count on the configuration screen in the next PR.
@sachinpro The default values for max file size and file count on the configuration screen are included in this PR—please refer to the screenshot in the PR description. The logging E2E test cases for these changes will be raised separately. |
3 participants
This PR fixes the logging trace file parameters
LogFileCountandLogFileSize. Log files are now created according to the values specified for these attributes. Also, default values also provided for log trace attributes. Additionally, the log file size unit has been changed fromMB to KB, and the same update has been applied in the UI as well.windows gha checks- https://github.com/googleapis/cpp-bigquery-odbc/actions/runs/23038050281
default values showing in ui:
installer url: https://drive.google.com/file/d/1_2HryH3iZi4sAsy7lOmZgU5RkXAa9hBb/view?usp=sharing