impl(bq_driver): add sql_wvarchar impl#1487
Draft
NeerajDwivedii wants to merge 2 commits into
Draft
Conversation
NeerajDwivedii
changed the title
NeerajDwivedii
changed the title
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
from
6aafd68 to
cf1be14
Compare
|
|
||
| TEST(StatementTest, UseWVarcharInsteadOfVarchar) { | ||
| auto conn = std::make_shared<ODBCHandles>(); | ||
| std::string const conn_str = kDefaultConnectionString + ";UseWVarChar=1"; |
Collaborator
There was a problem hiding this comment.
I don't think this test case makes sense, even if you don't use the 'UseWVarChar' param, it will still pass, please check this
Collaborator
Author
There was a problem hiding this comment.
If we don't utilize UseWVarChar then test case will fail. It's verified.
Collaborator
There was a problem hiding this comment.
please verify separately as SQLGetData and SQLBindCol test parts looks generic
Collaborator
Author
There was a problem hiding this comment.
Yes, It's passing. Removed now
| case SQL_INTERVAL_DAY_TO_SECOND: | ||
| case SQL_INTERVAL_HOUR_TO_SECOND: | ||
| case SQL_INTERVAL_MINUTE_TO_SECOND: | ||
| IntValueToOutputBufferResponse<SQLSMALLINT, SQLSMALLINT>( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
Author
There was a problem hiding this comment.
Reverted, Done
| octet_length = value * sizeof(SQLWCHAR); | ||
| break; | ||
| case SQL_WVARCHAR: | ||
| octet_length = value * 4; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
Author
There was a problem hiding this comment.
The value 8 is wrong. The size of SQLWCHAR is 2 on Windows and 4 on Linux. But after the latest existing driver update, it uses 4 for both systems
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
3 times, most recently
from
eea86eb to
86bf350
Compare
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
2 times, most recently
from
5b0276b to
c0d9b8d
Compare
NeerajDwivedii
force-pushed
the
add_max_retries
branch
from
54ec4fb to
c9a4838
Compare
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
2 times, most recently
from
db6011c to
3f17dff
Compare
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
2 times, most recently
from
af17c2b to
de70384
Compare
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
from
0fa1ca9 to
db2ac3b
Compare
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
from
db2ac3b to
6db07a9
Compare
NeerajDwivedii
force-pushed
the
add_sql_wvarchar_varchar_ui_impl
branch
from
6db07a9 to
041a6a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the UI feature and internal support for
UseWVarCharas described in the ticket. TheUseWVarCharoption can be configured through the driver UI, odbc.ini, and the connection string.windows gha checks: https://github.com/googleapis/cpp-bigquery-odbc/actions/runs/24066772452
Installer: https://drive.google.com/file/d/1Qb0qeLx_WmqIXMXw-G0Ac2fRPkB2ytJi/view?usp=drive_link
Here are Screenshot for same:
Note: I verified the current PR implementation of
SQLGetDataandSQLFetchwithUseWVarCharboth enabled and disabled. In both cases, the existing driver and the BQ driver behave the same—data is returned aswchareven whenUseWVarCharis disabled. Screenshots are attached for reference.