impl: PartnerToken configuration property#1489
Open
sachinpro wants to merge 1 commit into
Open
Conversation
sachinpro
force-pushed
the
partnerToken_impl
branch
8 times, most recently
from
af29b28 to
2dd0285
Compare
sachinpro
force-pushed
the
partnerToken_impl
branch
from
2dd0285 to
e269a8c
Compare
logachev
reviewed
Apr 10, 2026
| std::string partner_token = *partner_token_or; | ||
| options.set<google::cloud::UserAgentProductsOption>( | ||
| {"Google-Bigquery-ODBC/" + std::string(DRIVER_VERSION)}); | ||
| {"Google-Bigquery-ODBC/" + std::string(DRIVER_VERSION) + partner_token}); |
There was a problem hiding this comment.
nit: make a new std::string with the user-agent value to avoid mismatch between here & later in code?
| namespace { | ||
|
|
||
| TEST(ParsePartnerToken, ValidFull) { | ||
| std::string raw = "(GPN:PartnerName; Environment)"; |
There was a problem hiding this comment.
nit: remove space here to cover that scenario too?
| std::string kms_key_name; | ||
| std::string psc; | ||
| TPC tpc; | ||
| std::string partner_token; |
There was a problem hiding this comment.
I'd suggest creating new struct for "connection properties". partner_token doesn't logically belong to oauth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing
PartnerTokenoptional configuration parameter as done for JDBC.