fix(bq_driver): Update windows pipeline by Khushikathuria008 · Pull Request #1530 · googleapis/cpp-bigquery-odbc

Khushikathuria008 · 2026-05-12T06:06:12Z

In this PR, we update the Windows GHA pipeline. Previously, the pipeline relied on a pre-uploaded installer, which was downloaded and used for integration testing. With this change, we now build the installer within the pipeline itself and use the generated artifact for running the integration test cases.

Gha & macos pipe check here.

shivamd-gpartner · 2026-05-12T08:29:45Z

    env:
      DRIVER_ARCH: ${{ matrix.arch }}
      BUILD_SHARD: ${{ matrix.shard }}
+      ODBC_GOOGLE_DRIVER_VERSION: 1.1.3


no need to specify this version itself, can give any default version

shivamd-gpartner · 2026-05-12T08:30:45Z

 }
 if($env:BUILD_SHARD -eq 'Core'){
 $env:ODBC_DRIVER_MSI_NAME = "SimbaODBCDriverforGoogleBigQuery${arch}_${env:ODBC_DRIVER_VERSION}.msi"
-}else{


instead of separate install step for our driver and existing driver, can build the driver upload to GCS and download and install from path here itself

shivamd-gpartner · 2026-05-12T08:31:31Z

+        echo "Building version: $version"
+        cmake -S . -B build \
+          -G Ninja \
+          -DCMAKE_BUILD_TYPE=debug \


why do we need to specify, debug build type, it will anyway build in debug

sachinpro · 2026-05-13T09:12:36Z

@@ -27,7 +27,6 @@ if ($CI_CLOUDBUILD_BUILDS_LIB_ODBC_DRIVER_INSTALL_SH__ -ne $null -and ++$CI_CLOU
 # Set Environment Variables


Let's modify this script to read the driver version for both the existing and our driver. Don't rely on ODBC_DRIVER_VERSION env.

sachinpro · 2026-05-13T09:17:08Z

+            if [ $? -eq 0 ]; then
+              echo "Copied $f successfully."
+            else
+              echo "Failed to copy $f."


This step should fail in case of any error.

sachinpro · 2026-05-13T09:17:12Z

+              echo "Failed to copy $f."
+            fi
+          else
+            echo "$f not found in source directory: $SOURCE_DIR"


This step should fail in case of any error.

sachinpro · 2026-05-13T09:18:07Z

+
+        for f in "${FILES[@]}"; do
+          if [ -f "$SOURCE_DIR/$f" ]; then
+            cp -v "$SOURCE_DIR/$f" "$DEST_DIR/"


Use mv here.

sachinpro · 2026-05-13T09:18:38Z

          sed -i '/"arrow",/d' vcpkg.json
        fi
+
        ci/gha/builds/windows-cmake-integration.sh


We can directly run the tests built previously.

sachinpro · 2026-05-13T09:20:05Z

+        export CLOUDSDK_PYTHON="${{ steps.py311.outputs.python-path }}"
+        export CMAKE_OUT="c:/b"
+        export SCCACHE_IGNORE_SERVER_IO_ERROR=1
+        unset SCCACHE_GCS_BUCKET SCCACHE_GCS_KEY_PREFIX SCCACHE_GCS_RW_MODE


Add a TODO here to justify this. We shouldn't be disabling sccache.

sachinpro · 2026-05-13T09:20:30Z

+
+        export MSVC_VERSION="${{ matrix.msvc }}"
+        export BRANCH_IDENTIFIER=$(echo "${{ github.ref_name }}" | tr '[:punct:]' '_')
+        export CPP_BIGQUERY_ODBC_TEST_TABLE_PREFIX="windows_${BRANCH_IDENTIFIER}_${MSVC_VERSION//[-:;.,?\/]/_}_${DRIVER_ARCH}_$BUILD_SHARD"


This is not needed for building the driver.

sachinpro · 2026-05-13T09:21:02Z

+          -DVCPKG_TARGET_TRIPLET="${VCPKG_TRIPLET}" \
+          -DODBC_EXAMPLES=OFF \
+          -DODBC_UNIT_TESTING=OFF \
+          -DODBC_INTEGRATION_TESTING=OFF \


ODBC_INTEGRATION_TESTING=ON so we can run the tests later.

sachinpro · 2026-05-13T09:21:25Z

+          -DODBC_UNIT_TESTING=OFF \
+          -DODBC_INTEGRATION_TESTING=OFF \
+          -DCLIENT_LIBRARY_INTEGRATION_TESTING=OFF \
+          -DBQ_DRIVER_INTEGRATION_TESTS=OFF \


BQ_DRIVER_INTEGRATION_TESTS=ON so we can run the tests later.

sachinpro · 2026-05-13T09:29:01Z

+      if: env.BUILD_SHARD == 'BqDriver'
+      shell: pwsh
+      env:
+        GCS_BUCKET: bq-dev-tools-testing-drivers


Use odbc-integration-builds bucket to push the artifacts.

sachinpro · 2026-05-13T09:30:08Z

+        $MSI_DIR = "ci/installer/ODBCDriverForBigQuery/bin/Release/en-us"
+        $MSI_FILE = "ODBCDriverforBigQuery_windows_$($env:DRIVER_ARCH)_${{  env.ODBC_GOOGLE_DRIVER_VERSION }}.msi"
+
+        Write-Output "Uploading $MSI_FILE to gs://$env:GCS_BUCKET/odbc-windows/$arch/ ..."


The folder inside the GCS_BUCKET should be the branch name. Create the folder if it doesn't exist. x64 and x32 installers for a branch will be pushed to the same folder.

shivamd-gpartner · 2026-05-14T10:29:49Z

          sed -i '/"arrow",/d' vcpkg.json
        fi
-        ci/gha/builds/windows-cmake-integration.sh
+        if [ "$BUILD_SHARD" == "BqDriver" ]; then


why do we need a check here? we can remove the file windows-cmake-integration.sh as that is not needed anymore

Khushikathuria008 temporarily deployed to internal May 12, 2026 06:06 — with GitHub Actions Inactive

shivamd-gpartner reviewed May 12, 2026

View reviewed changes

Khushikathuria008 force-pushed the windows_pipeline_fix branch from d39454d to 616eb46 Compare May 12, 2026 08:41

Khushikathuria008 temporarily deployed to internal May 12, 2026 08:41 — with GitHub Actions Inactive

Khushikathuria008 force-pushed the windows_pipeline_fix branch from e8a624a to 51e8325 Compare May 12, 2026 09:44

Khushikathuria008 temporarily deployed to internal May 13, 2026 05:33 — with GitHub Actions Inactive

shivamd-gpartner marked this pull request as ready for review May 13, 2026 05:49

shivamd-gpartner requested a review from a team as a code owner May 13, 2026 05:49

shivamd-gpartner requested a review from sachinpro May 13, 2026 05:49

sachinpro reviewed May 13, 2026

View reviewed changes

sachinpro requested changes May 13, 2026

View reviewed changes

Khushikathuria008 force-pushed the windows_pipeline_fix branch from 51e8325 to 329d2af Compare May 14, 2026 10:24

Khushikathuria008 temporarily deployed to internal May 14, 2026 10:26 — with GitHub Actions Inactive

Khushikathuria008 requested a review from sachinpro May 14, 2026 10:28

shivamd-gpartner reviewed May 14, 2026

View reviewed changes

Khushikathuria008 force-pushed the windows_pipeline_fix branch from 329d2af to afef2a8 Compare May 14, 2026 10:55

Khushikathuria008 temporarily deployed to internal May 14, 2026 10:57 — with GitHub Actions Inactive

Khushikathuria008 force-pushed the windows_pipeline_fix branch from afef2a8 to 47add82 Compare May 14, 2026 10:59

fix(bq_driver): Update windows pipeline

159c903

Khushikathuria008 force-pushed the windows_pipeline_fix branch from 47add82 to 159c903 Compare May 14, 2026 11:07

Khushikathuria008 temporarily deployed to internal May 14, 2026 11:12 — with GitHub Actions Inactive

		@@ -27,7 +27,6 @@ if ($CI_CLOUDBUILD_BUILDS_LIB_ODBC_DRIVER_INSTALL_SH__ -ne $null -and ++$CI_CLOU
		# Set Environment Variables

Conversation

Khushikathuria008 commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Khushikathuria008 commented May 12, 2026 •

edited

Loading