-
Notifications
You must be signed in to change notification settings - Fork 345
feat: add httpx transport; add compute_engine async #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Super cool! I will give this a thorough read later. Two high level questions I have for you.
|
|
Oh this is exactly what I'd need. httpx is such a brilliant library, it would be awesome of the Google auth client could natively support it. |
|
This PR has been here a long time.
Having said that, we are actively pushing to migrate most of our libraries to our python monorepo** (which means we need to disposition all Open PRs). I recommend we close this PR for the moment and tackle this project as soon as the migration to the mono-repo is complete. To move this concept to something that can be incorporated in the library, I strongly recommend the action items listed below. I leveraged Jules to attempt to do these things and Jules issued a PR that builds on this foundation and attempts to resolve the following:
** One of the reasons for this push is to reduce the duplicative toil we have across all our split repos. Reducing time on toil frees us up to focus more on adding features such as this. |
|
Added an issue to track this post migration. See Issue #1908 |
Opening a draft PR to gauge interest in adding an httpx transport.
This is used internally for a project that otherwise relied on httpx (instead of aiohttp) for async http requests. Using this httpx transport means that the response from an
AuthorisedSessionis anhttpx.Resposelike the other responses in our code.Frankly, this a copy/paste job from
_aiohttp_requests.pywith relevant parts changed.compute_engine._credentials_async.pyis also added for async Compute Engine credentials. Arguably, this should be discussed separately, but was created while developing the httpx transport.There is more work to be done before this could merge, but please discuss and provide feedback.