-
Notifications
You must be signed in to change notification settings - Fork 346
chore: improve metadata service error handling #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve metadata service error handling #1902
Conversation
Distinguish between retry exhaustion due to exceptions and retry exhaustion due to retryable status codes. - Use `last_exception` to track the most recent exception. - Clear `last_exception` on successful response (even if status is retryable). - Raise TransportError chained from `last_exception` if available. - Otherwise raise TransportError with response status and details. - Update tests to match new error format.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Distinguish between retry exhaustion due to exceptions and retry exhaustion due to retryable status codes. - Use `last_exception` to track the most recent exception. - Clear `last_exception` on successful response (even if status is retryable). - Raise TransportError chained from `last_exception` if available. - Otherwise raise TransportError with response status and details. - Update tests to match new error format.
chalmerlowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Improved error handling in
google/auth/compute_engine/_metadata.pyto provide more informative error messages when retries are exhausted.The logic now handles two distinct failure modes:
Connection Errors (Exceptions):
last_exception.last_exceptionis set, aTransportErroris raised that chains the original exception. This preserves the stack trace and specific error type for debugging.Retryable HTTP Status Codes:
last_exceptionis cleared (set toNone).TransportErroris raised that includes theresponse.statusand the response body (error_details). This ensures the specific server error message is visible.This addresses feedback from PR 1637 by ensuring that "Ran out of retries" scenarios provide the most relevant context: either the underlying exception or the final HTTP error response.
PR created automatically by Jules for task 6226991344715693997 started by @chalmerlowe